Change in ovirt-dwh[master]: build: ovirt-engine-dwh-4.2.0
by Code Review
>From Shirly Radco <sradco(a)redhat.com>:
Shirly Radco has submitted this change and it was merged. ( https://gerrit.ovirt.org/79872 )
Change subject: build: ovirt-engine-dwh-4.2.0
......................................................................
build: ovirt-engine-dwh-4.2.0
Added release notes.
Change-Id: I89e67f3d6040f22ee9606db0529404f58e4f0135
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M ovirt-engine-dwh.spec.in
M version.mak
2 files changed, 10 insertions(+), 2 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79872
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89e67f3d6040f22ee9606db0529404f58e4f0135
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: aaa: Flood of log: Unable to cleanup SsoSession
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/79809 )
Change subject: aaa: Flood of log: Unable to cleanup SsoSession
......................................................................
aaa: Flood of log: Unable to cleanup SsoSession
If a session was invalidated by the
container before SSO gets a chance to clean
up expired sessions an IllegalStateException
is thrown. The log is flooded with messages
from the exception. Log the messages as debug
messages for such exceptions.
Change-Id: Id470fc204d7d7f2512a1858e0577bd48be269b96
Bug-Url: https://bugzilla.redhat.com/1474482
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/TokenCleanupUtility.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79809
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id470fc204d7d7f2512a1858e0577bd48be269b96
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: fix NPE when increasing the number of vms in a pool
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79812 )
Change subject: core: fix NPE when increasing the number of vms in a pool
......................................................................
core: fix NPE when increasing the number of vms in a pool
When a VM pool is created from a template that is not set with VM-init
(neither sysprep nor cloud-init) and the pool is configured with
VM-init that includes root password, an NPE is thrown while trying to
increase the number of VMs in the pool because the VM is set with the
'passwordAlreadyStored' flag on and thus, the engine tries to take the
password from the VM-init of the template that the pool is based on.
This patch fixes this issue by changing the setting of the password
of a VM that is added to such a pool so the password would be taken
from one of the VMs in the pool rather than from the template. This is
what we generally do in order to get the properties of VMs that are
part of a VM pool. This may stil be problematic if the VM-init part of
the chosen VM was removed. However, this case is really not likely to
happen so in this case we just clear the password.
Change-Id: Id7939138daf12809a5551da5221fb2483a03dce0
Bug-Url: https://bugzilla.redhat.com/1474352
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolCommand.java
3 files changed, 29 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79812
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7939138daf12809a5551da5221fb2483a03dce0
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add section for aux. documentation
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79857 )
Change subject: inventory: Add section for aux. documentation
......................................................................
inventory: Add section for aux. documentation
Let's help users with tips and find quicky our official documentation.
Change-Id: I667f31a040a659bbfac832ae1991debf8fa6461a
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
A src/inventory_report/produceReport/docs-helper
M src/inventory_report/produceReport/produceReport.sh
3 files changed, 39 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79857
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I667f31a040a659bbfac832ae1991debf8fa6461a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-log-collector[master]: inventory: Add section for aux. documentation
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79697 )
Change subject: inventory: Add section for aux. documentation
......................................................................
inventory: Add section for aux. documentation
Let's help users with tips and find quicky our official documentation.
Change-Id: I667f31a040a659bbfac832ae1991debf8fa6461a
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
A src/inventory_report/produceReport/docs-helper
M src/inventory_report/produceReport/produceReport.sh
3 files changed, 39 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79697
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I667f31a040a659bbfac832ae1991debf8fa6461a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jiri Belka <jbelka(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: include vm lease info in the engine xml
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79372 )
Change subject: core: include vm lease info in the engine xml
......................................................................
core: include vm lease info in the engine xml
Now that the info on VM leases in stored in the database, we can
generate the complete elements of VM leases on the engine side.
Change-Id: If80f85e776307913f27f57b6722a7e225167e287
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
2 files changed, 5 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79372
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If80f85e776307913f27f57b6722a7e225167e287
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: upgrade: unset XDG_RUNTIME_DIR before calling libguestfs
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged. ( https://gerrit.ovirt.org/79784 )
Change subject: upgrade: unset XDG_RUNTIME_DIR before calling libguestfs
......................................................................
upgrade: unset XDG_RUNTIME_DIR before calling libguestfs
Newer (> 1.32 - RHEL 7.4) version of libguestfs relies on the value
of XDG_RUNTIME_DIR, if set, to choose its temporary directory.
Since we are changing from root user to vdsm user, we have to
unset XDG_RUNTIME_DIR as well.
Bug-Url: https://bugzilla.redhat.com/1467813
Change-Id: Icda24ad4cc381126ddc094377babf413457e5eb7
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit 6a5eed388f6985c9dd3e092cced6bee7e20b8d6b)
---
M src/plugins/gr-he-common/vm/boot_disk.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79784
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icda24ad4cc381126ddc094377babf413457e5eb7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.1
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: calculate elapsed time in the engine
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/78620 )
Change subject: core: calculate elapsed time in the engine
......................................................................
core: calculate elapsed time in the engine
This change opens the door for two possible improvements:
1. To drop the reports of elapsed time from the host. This is not
likely to happen at this point though.
2. To drop the metadata volume in snapshots with memory and when
suspending the VM. That may happen.
Change-Id: I489ccfd5ebf1d9c0147ab0df25bb53bc61a538e3
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78620
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I489ccfd5ebf1d9c0147ab0df25bb53bc61a538e3
Gerrit-PatchSet: 29
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: store vm lease info in the engine
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79226 )
Change subject: core: store vm lease info in the engine
......................................................................
core: store vm lease info in the engine
We want to be able to generate as much data as we can in the domain XML
on the engine side. The info on lease devices is a static data that can
be stored in the database and used when generating the engine XML.
Change-Id: Iaa71b2c66ff31e7c4f0d9a1992ba63bda8efdda9
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lease/AddVmLeaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDaoImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmLeaseInfoVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LeaseInfoReturn.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_02_0440_add_vm_lease_info.sql
M packaging/dbscripts/vms_sp.sql
18 files changed, 195 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79226
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa71b2c66ff31e7c4f0d9a1992ba63bda8efdda9
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in jenkins[master]: Fix he and hc suites name
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged. ( https://gerrit.ovirt.org/79841 )
Change subject: Fix he and hc suites name
......................................................................
Fix he and hc suites name
Suite names should be he-basic and hc-basic
and not just he or hc
Change-Id: I4043f17345ca8b505810cbe2754ce903b7d48778
Signed-off-by: Gil Shinar <gshinar(a)redhat.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved; Ready for merge
Gil Shinar: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79841
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4043f17345ca8b505810cbe2754ce903b7d48778
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 10 months