<div dir="ltr">Hi Adam<div><br></div><div>Thanks for the feedback </div><div><br><div class="gmail_extra"><div class="gmail_quote">2014/1/3 Adam Litke <span dir="ltr"><<a href="mailto:alitke@redhat.com" target="_blank">alitke@redhat.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div>On 03/01/14 12:20 +0000, Dan Kenigsberg wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Recently, Miguel Angel Ajo (CCed) has added a nice functionality to the<br>
implementation of setupNetworks in Vdsm: two hook points where added:<br>
before and after the setupNetworks verb takes place.<br>[....]</blockquote></div></div>
Seems like a logical thing to do. What specific mechanism do you<br>
suggest for passing the JSON strings to the hook script? If passed as<br>
arguments to the hook script we would need to consider shell escaping<br>
and argv length restrictions.<br>
<br></blockquote><div>As for the libvirt domain xml we pass to other hooks, we write a temporary file</div><div>and we set an environment variable pointing to it before calling the script</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
What about writing these out to a special file and adding a new<br>
getContext() call to the hooking module. A script that is unconcerned<br>
with the context would not require any changes. But a script that<br>
wants access would simply do:<br>
<br>
ctx = hooking.getContext()<br>
<br>
and ctx would be the contents of the special file already decoded into<br>
a native Python object for easy consumption. This could easily be<br>
extended to any hook which may want to provide some context to<br>
implementors.<br></blockquote><div><br></div><div>That would be nice, so scripts written in python wouldn't need to look for, and parse</div><div>the file.</div><div><br></div><div>This is an example of a simple hook:</div>
<div><br></div><div><a href="http://gerrit.ovirt.org/#/c/20330/7/tests/functional/networkTests.py">http://gerrit.ovirt.org/#/c/20330/7/tests/functional/networkTests.py</a> (look inside the ValidatesHook decorator)<br></div>
<div> </div><div><br></div><div>It'd be quite simplified. We would also need a "setContext()..." to update context with changes.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
One more question comes to mind: Are there any pieces of information<br>
that we would need to redact from the context (passwords or other<br>
sensitive information)?<br>
<br></blockquote><div><br></div><div>I think there is no sensitive information as far as I know.</div><div><br></div><div>Greetings,</div><div>Miguel Ángel.</div><div> </div></div></div></div></div>