[Engine-devel] jaxb annotations

[Roy Golan]

On Fri 16 Dec 2011 01:37:55 PM IST, Itamar Heim wrote:
>
>
>> -----Original Message-----
>> From: engine-devel-bounces at ovirt.org
> [mailto:engine-devel-bounces at ovirt.org] On Behalf Of Laszlo Hornyak
>> Sent: Friday, December 16, 2011 12:25 PM
>> To: engine-devel at ovirt.org
>> Subject: [Engine-devel] jaxb annotations
>>
>> Hi!
>>
>> I ran into some jaxb-annotated beans in engine, and the annotations
> seemed to be a bit unsettled.
>> - Some annotations are on the field, some on the getter.
>> - I have also found a case where the setter is private, it is actually
> dead code. I was puzzled for a
>> minute :-) It seems in this case jaxb actually sets the value through
> reflection, so the setter really is
>> dead code.
>
> Iirc, we found CXF broke if a serialized property didn't have a setter.
>
>> - Some annotations state name, others just build on the defaults
>>
>> Is there an agreement for the annotations?
>>
>> It would be great if we could annotate the getter always and use a
> proper name in the @XmlElement
>> annotation even if it is equal to the default, so it is less likely to
> break at refactoring.
>
> I think they are pretty much dead code now that the WPF is not user any
> more.
>
>>
>> Laszlo
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

Yes the its the end of the soap api and now its possible to refactor it 
and make it more standard (proper namings etc)