[Engine-devel] Shared Raw Disk - Design change

[Maor Lipchuk]

Thanks for the comments,
Please see responds in the message body.

On 03/13/2012 04:47 PM, Itamar Heim wrote:
> On 03/12/2012 11:01 AM, Maor Lipchuk wrote:
>> Hello all,
>>
>> The shared raw disk feature description has been changed.
>> The changes can be found in the following wiki:
>> links:
>>     http://www.ovirt.org/wiki/Features/SharedRawDisk
>>     http://www.ovirt.org/wiki/Features/DetailedSharedRawDisk
> 
> 1. affected components - isn't vdsm aware of this as well wrt disk lock
> protection (appears in both urls)
You right, Backend sends VDSM an indication when ever we create a VM
whether the disk is shared or not.
I Added the OVirt Node, as a related component in the dependencies tab
at the wiki.
> 
> 2. Remove Shared Disk
> maybe make it clear this is about delete, not detach from this vm?
> my view - UI should have a clear warning (with checkbox approval) making
> it clear delete will remove the shared disk from all VMs sharing it.
I tried to stay consistent with the semantic here, by not mentioning
delete and remove in the same sentence.
I changed it to be as follow:

User can remove the shared raw disk entirely from the setup, whether the
disk is inactive in all the VMs which are attached to it, or all the VMs
which the disk is attached to, are in status down (or any combination of
the two).
When disk will be removed a warning message should display the user the
following message :

"Removing the shared disk will remove it from all the VMs which are
associated with it."

> 
> 3. Copy Shared Disk
> this is "clone disk"? do we have it for non shared disks?
I'm not sure I understood completely.
Move disk for shared disk, will need to have the same functionality as
regular disk, the only difference is that fir shared disk I check all
the VMs which the disk is attached to, whether the disk is inactive in
the running VMs or attached to non active VMs.>
> 4. Export/Import
> the text is copy/paste from template part - should be fixed to say
> export in several places.
Fixed, although I found only one mention of template there, hope I
didn't missed something.
> 
> 5. move disk
> s/inactivatee/inactive/
Fixed, thank you.
> 
> Thanks,
>   Itamar