[Engine-devel] Changes in DB scripts that need your attension

[Eli Mesika]

----- Original Message -----
> From: "Alon Bar-Lev" <alonbl at redhat.com>
> To: "Eli Mesika" <emesika at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Thursday, April 18, 2013 12:26:44 PM
> Subject: Re: [Engine-devel] Changes in DB  scripts that need your attension
> 
> Hi,
> 
> ----- Original Message -----
> > From: "Eli Mesika" <emesika at redhat.com>
> > To: "engine-devel" <engine-devel at ovirt.org>
> > Sent: Thursday, April 18, 2013 12:19:43 PM
> > Subject: [Engine-devel] Changes in DB  scripts that need your attension
> > 
> > Hi
> > 
> > As part of solving https://bugzilla.redhat.com/show_bug.cgi?id=947344 I am
> > doing the following changes:
> > 
> > 1) Create all *.md5 files in /tmp/db
> 
> Please use mkstemp or equivalent to create unique temp directory.

OK, will use mktemp -d for that

> 
> > 2) Create db log files by default under /var/log/ovirt-engine/db
> 
> Please allow to override log location and/or output logs to stdout.
> This will make it easier to run it within installer so that the log will be
> available at installer log.


All scripts supports the -l LOGFILE flag 

> 
> > 3) Do not automatically create a *.schema file that represent the
> > up-to-date
> > schema (after all upgrades took place)
> >    A new utility script exportDbSchema.sh will be available for that
> >    (manual
> >    only, no auto-generation schema)
> >    
> > In order that DB scripts in development environment will keep working,
> > please
> > do
> > 
> > > sudo mkdir -p /var/log/ovirt-engine/db
> > > sudo chmod 777 /var/log/ovirt-engine/db
> 
> 777 access permission is not something that should exist in system anywhere,
> well apart of /tmp and /tmp is marked using 't' attribute.
> 
> Regards,
> Alon
>