[Engine-devel] How to validate no arg ctor existence in params?

Tal Nisan tnisan at redhat.com
Mon Oct 7 14:06:52 UTC 2013


On 10/07/2013 05:04 PM, Einav Cohen wrote:
>> ----- Original Message -----
>> From: "Yair Zaslavsky" <yzaslavs at redhat.com>
>> Sent: Monday, October 7, 2013 10:02:39 AM
>>
>>
>>
>> ----- Original Message -----
>>> From: "Tal Nisan" <tnisan at redhat.com>
>>> To: "Yair Zaslavsky" <yzaslavs at redhat.com>
>>> Cc: "engine-devel" <engine-devel at ovirt.org>
>>> Sent: Monday, October 7, 2013 4:56:52 PM
>>> Subject: Re: [Engine-devel] How to validate no arg ctor existence in
>>> params?
>>>
>>> Perhaps it can be done by writing a custom checkstyle plugin? Allon
>>> wrote one for alerting when using a static class members initialization
>>> in certain packages, he might know.
>> +1
>> Martin Perina also remembered something like that.
>> Anyway, I strongly recommend it should be done.
>> Already corresponding with Allon on it.
> I might be missing something, but isn't that what patch http://gerrit.ovirt.org/#/c/18910/ does?
Seems like it, Yair I saw you also reviewed it, from a brief look at the 
code it looks like it checks for a default constructor existence as well 
as some other criterias
>
>>> On 10/07/2013 04:52 PM, Yair Zaslavsky wrote:
>>>> Hi,
>>>> I saw several patches that fixed serialization (json or gwt) issues that
>>>> were introduced due to non existence of no-arg CTOR for parameters.
>>>> Does anyone know a way to validate this using  let's say some jenkins
>>>> plugin?
>>>>
>>>> Yair
>>>> _______________________________________________
>>>> Engine-devel mailing list
>>>> Engine-devel at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>>
>>




More information about the Devel mailing list