[Engine-devel] ui code: possible problem in 'remove' confirmation dialog

[Einav Cohen]

[apologies - previous e-mail sent prematurely by mistake]

Hi,
 
Looking at the current code: It seems that we cannot set the message within a
'remove' confirmation dialog if its HashName starts with "remove_" - it is 
being set "statically" to the "Are you sure you want to remove the following 
items?" [constants.removeConfirmationPopupMessage] message [1]

I don't have a major problem with relying on the HashName for setting a
*default* message [2] - but I think that not allowing to override this 
message if the developer chooses to do so is an incorrect behavior.

I would like to change the behavior so that the user would be able to 
override the message displayed in that dialog, even if its hash-name is 
set to 'remove_'. 

thoughts? objections?

----
Thanks,
Einav
 

[1] From RemoveConfirmationPopupView.java, line 86:
 
     public void setMessage(String message) {
         if (getHashName() != null && getHashName().startsWith("remove_")) {
         //$NON-NLS-1$
             super.setMessage(constants.removeConfirmationPopupMessage());
         } else {
             super.setMessage(message);
         }
     }

[2] in fact, I don't mind that this would be the default message for 
this dialog, even if its hash-name is not set to something that starts 
with 'remove_'.

----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Daniel Erez" <derez at redhat.com>, "Gilad Chaplik" <gchaplik at redhat.com>, "Tomas Jelinek" <tjelinek at redhat.com>,
> "Vojtech Szocs" <vszocs at redhat.com>, "Lior Vernia" <lvernia at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Thursday, October 17, 2013 9:20:07 AM
> Subject: ui code: possible problem in 'remove' confirmation dialog
> 
> Hi,
> 
> Looking at the current code: It seems that we cannot set the message within a
> 'remove' confirmation
> dialog if its HashName starts with "remove_" - it is being set "statically[1]
> I don't have a major problem with relying on the HashName for setting a
> *default* message (in fact,
> I don't have a problem
> 
> [1] From RemoveConfirmationPopupView.java, line 86:
> 
>     public void setMessage(String message) {
>         if (getHashName() != null && getHashName().startsWith("remove_")) {
>         //$NON-NLS-1$
>             super.setMessage(constants.removeConfirmationPopupMessage());
>         } else {
>             super.setMessage(message);
>         }
>     }
> 
> ----
> Regards,
> Einav Cohen Baum
> RHEV-M Engineering - UX Team Manager
> Red Hat, Inc.
> 314 Littleton Road
> Westford, MA 01886
> T [internal]: (81) 31046
> T [external]: (+1) 978 589 1046
> IRC: ecohen @
>  - RHAT [internal]: #rhev-dev #boston #westford #tlv
>  - OFTC [external]: #ovirt
>