[Engine-devel] which data structure is better

Doron Fediuck dfediuck at redhat.com
Tue Feb 25 04:09:11 UTC 2014



----- Original Message -----
> From: "Eli Mesika" <emesika at redhat.com>
> To: "Liran Zelkha" <liran.zelkha at gmail.com>
> Cc: engine-devel at ovirt.org, "Chegu Vinod" <chegu_vinod at hp.com>, "Shang-Chun Liang (David Liang,
> HPservers-Core-OE-PSC)" <shangchun.liang at hp.com>
> Sent: Thursday, February 20, 2014 2:42:36 PM
> Subject: Re: [Engine-devel] which data structure is better
> 
> 
> 
> ----- Original Message -----
> > From: "Liran Zelkha" <liran.zelkha at gmail.com>
> > To: "Chuan Liao (Jason Liao, HPservers-Core-OE-PSC)" <chuan.liao at hp.com>
> > Cc: engine-devel at ovirt.org, "Chegu Vinod" <chegu_vinod at hp.com>, "Shang-Chun
> > Liang (David Liang,
> > HPservers-Core-OE-PSC)" <shangchun.liang at hp.com>
> > Sent: Thursday, February 20, 2014 11:40:57 AM
> > Subject: Re: [Engine-devel] which data structure is better
> > 
> > Hi
> > 
> > Please don't add rapidly changing data to VDSDynamic - it has major
> > performance implications.
> > So, choose option B. Actually, try to expose relevant data in VDSDynamic
> > and
> > VDSStatistics, and VDS should call VDSDynamic and VDSStatistics and merge
> > the data from both entities.
> 
> Agree.We had lately several bottle-necks around the VDS/VM updates and Liran
> had improved the relevant queries and added batch-update stuff, so we want
> to keep the performance gain
> 

Jason,
in order for us to know which node can accommodate which VM we need to get
the memory statistics of each NUMA node as well (usage and free). Also, if
possible CPU usage in every node.

> > 
> > 
> > On Thu, Feb 20, 2014 at 11:31 AM, Liao, Chuan (Jason Liao,
> > HPservers-Core-OE-PSC) < chuan.liao at hp.com > wrote:
> > 
> > 
> > 
> > 
> > 
> > Hi All,
> > 
> > 
> > 
> > I am Jason Liao from HP who are in charge of NUMA and Virtual NUMA feature.
> > 
> > 
> > 
> > Now I have some concept about the host NUMA topology data structure on
> > engine
> > core
> > 
> > 
> > 
> > We have VDS, VDSDynamic, VDSStatic, VdsStatistics object on engine core.
> > 
> > 
> > 
> > And we have NUMA topology information:
> > 
> > List<NumaNode> numaNodeList
> > 
> > NumaNode
> > 
> > String ID # update from GetCapabilitiesVDSCommand
> > 
> > List<String> cpuList # update from GetCapabilitiesVDSCommand
> > 
> > Int totalMem # update from GetCapabilitiesVDSCommand
> > 
> > Int freeMem # update from GetStatsVDSCommand
> > 
> > 
> > 
> > A. Add this data structure into VDSDynamic
> > 
> > We should change the GetStatsVDSCommand update the VDSDynamic data.
> > 
> > B. Add this data structure into VDS, and build the data structure from
> > VDSDynamic, VdsStatistics
> > 
> > 
> > 
> > I prefer B. does anybody have some comments?
> > 
> > 
> > 
> > Best Regards,
> > Jason Liao
> > 

> 



More information about the Devel mailing list