[ovirt-devel] Merging patches into vdsm without CI

[Dan Kenigsberg]

On Mon, Aug 24, 2015 at 03:32:53AM -0400, Francesco Romani wrote:
> ----- Original Message -----
> > From: "Dan Kenigsberg" <danken at redhat.com>
> > To: "David Caro" <dcaro at redhat.com>
> > Cc: "Adam Litke" <alitke at redhat.com>, fromani at redhat.com, devel at ovirt.org, "Sandro Bonazzola" <sbonazzo at redhat.com>,
> > "David Caro Estevez" <dcaroest at redhat.com>
> > Sent: Monday, August 24, 2015 8:53:07 AM
> > Subject: Re: Merging patches into vdsm without CI
> > 
> > On Mon, Aug 24, 2015 at 12:01:58AM +0200, David Caro wrote:
> > > On 08/23, Dan Kenigsberg wrote:
> > > > On Fri, Aug 21, 2015 at 05:04:03PM -0400, Adam Litke wrote:
> > > > > Hi all,
> > > > > 
> > > > > Recent breakage in the vdsm CI flows have caused the change upload
> > > > > trigger to be disabled.  This means that CI scores are no longer being
> > > > > automatically applied to uploaded changes.  This means that patches
> > > > > cannot be merged into vdsm.  I have a queue of patches which are
> > > > > otherwise ready for merge (which have passed CI in the past but needed
> > > > > rebasing).  These patches have been stalled for almost a week now.
> > > > > 
> > > > > What can we to to "unfreeze" the vdsm development process in the short
> > > > > and long term?  Earlier today I worked with Sandro and David on
> > > > > manually running CI on my dev machine but am getting 100s of failures
> > > > > (so it looks like this wont even be a good short-term solution).
> > > > 
> > > > Francesco and David were supposed to revive the broken job on Friday,
> > > > but I see that it is still disabled.
> > > > 
> > > > What is the reason of the delay?
> > > 
> > > Francesco wanted the approval of the network guys, as the job has to create
> > > the
> > > tun char device itself (because mock does not do it).
> > > 
> > > 
> > > If that's allowable, then it can be enabled right away (you'll have to
> > > rebase
> > > to pull the scripts in).
> > 
> > I'm not sure how this can be done. but in any case, I'd rather
> > NOSE_EXCLUDE tcTests until we solve this issue.
> 
> Hi all,
> 
> this is true. I didn't want to rush in a possible half-baked "solution" without any ack
> from the owners of the tests.
> 
> With this patch: https://gerrit.ovirt.org/#/c/45134/3 the CI jobs WORKSFORME.
> 
> I used these instructions
> 
> http://www.ovirt.org/index.php?title=CI/Build_and_test_standards#Testing_the_scripts_locally
> 
> and tested on el7 and fc22 succesfully.

I've merged these patches (despite little comments that can wait for a
follow-up patch).

David, can you now enable CI on the master branch?
Later, Francesco, would you backport these two patches to 3.6?

Dan.