[ovirt-devel] AppErrors cleanup

Allon Mureinik amureini at redhat.com
Sun Dec 13 12:46:01 UTC 2015


Same has been done for AuditLogMessages.properties (vs. the AuditLogType
enum).

On Wed, Jul 29, 2015 at 3:51 PM, Allon Mureinik <amureini at redhat.com> wrote:

> Hi all,
>
> A recent bug [1] reported as part of the translation effort alerted me to
> the fact that we have a lot (and I mean a LOT - over 100 per file) of
> deprecated, unused keys in the various AppErrors files that serve no
> purpose and just take up space and waste translators time when they examine
> them.
>
> To make a long story short - I've just merged a patch to remove all these
> useless messages, and enforce via unit tests that EVERY key there should
> have a corresponding constant in the EngineMessage or EngineError enums.
>
> Many thanks to my reviewers!
> I know this was an tedious patch that couldn't have been too fun to review.
>
>
> -Allon
>
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1244766
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20151213/309af350/attachment-0001.html>


More information about the Devel mailing list