[ovirt-devel] Useless AddVmPoolCommand class

[Omer Frenkel]

----- Original Message -----
> From: "Shmuel Melamud" <smelamud at redhat.com>
> To: devel at ovirt.org
> Sent: Sunday, March 29, 2015 5:45:52 PM
> Subject: [ovirt-devel] Useless AddVmPoolCommand class
> 
> Hi!
> 
> Do we really need the AddVmPoolCommand class? What I see currently:
> 
> 1. VdcActionType.AddVmPool is never used.
> 2. CommonVmPoolWithVmsCommand extends AddVmPoolCommand, but this inheritance
> is useless:
>   a. AddVmPoolCommand.executeCommand() is never called from
>   CommonVmPoolWithVmsCommand.executeCommand(), the same work is done by
>   AddVmPoolWithVmsCommand.getPoolId().
>   b. AddVmPoolCommand.getAuditLogTypeValue() is never called.

so you can also remove the AuditLogType values used there, and the translations (if not in use)

>   c. AddVmPoolCommand.getValidationGroups() does the same as
>   AddVmPoolWithVmsCommand.getValidationGroups() and may be merged to
>   UpdateVmPoolWithVmsCommand.getValidationGroups() if needed (I'm not sure).
>   d. AddVmPoolCommand() constructor code may be merged to
>   CommonVmPoolWithVmsCommand() constructor.

just make sure current behavior is kept

> 3. The hierarchy where UpdateVmPoolWithVmsCommand is inherited indirectly
> from AddVmPoolCommand seems illogical.
> 
> So can AddVmPoolCommand be safely removed?
> 

yes

> --
> Shmuel
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>