[ovirt-devel] [VDSM] upgrading pylint - new errors

[Nir Soffer]

I'm trying to upgrade pylint to latest so we can enjoy latest fixes
like this:
https://github.com/PyCQA/pylint/issues/1736

Now we have some new errors, please check.

************* Module vdsm.clientIF*00:06:53.857* *E*:588,16: *Possible
unbalanced tuple unpacking with sequence: left side has 2 label(s),
right side has 0 value(s)* (*unbalanced-tuple-unpacking*)


587             if eventid == libvirt.VIR_DOMAIN_EVENT_ID_LIFECYCLE:
588                 event, detail = args[:-1]
589                 v.onLibvirtLifecycleEvent(event, detail, None)


Code is indeed incorrect, should be:

    event, detail = args[:2]


*00:06:53.859* *E*:593,16: *Possible unbalanced tuple unpacking with
sequence: left side has 1 label(s), right side has 0 value(s)*
(*unbalanced-tuple-unpacking*)*00:06:53.861* *E*:596,16: *Possible
unbalanced tuple unpacking with sequence: left side has 4 label(s),
right side has 0 value(s)*
(*unbalanced-tuple-unpacking*)*00:06:53.863* *E*:599,16: *Possible
unbalanced tuple unpacking with sequence: left side has 5 label(s),
right side has 0 value(s)*
(*unbalanced-tuple-unpacking*)*00:06:53.867* *E*:610,16: *Possible
unbalanced tuple unpacking with sequence: left side has 1 label(s),
right side has 0 value(s)*
(*unbalanced-tuple-unpacking*)*00:06:53.869* *E*:615,16: *Possible
unbalanced tuple unpacking with sequence: left side has 1 label(s),
right side has 0 value(s)*
(*unbalanced-tuple-unpacking*)*00:06:53.872* *E*:618,16: *Possible
unbalanced tuple unpacking with sequence: left side has 4 label(s),
right side has 0 value(s)*
(*unbalanced-tuple-unpacking*)*00:06:53.873* ************* Module
vdsm.v2v*00:06:53.874* *E*:1368,27: *Instance of 'closing' has no
'read' member* (*no-member*)*00:06:53.876* ************* Module
vdsm.tool.configurator*00:06:53.878* *E*:118,12: *No value for
argument 'action' in function call*
(*no-value-for-parameter*)*00:06:53.880* *E*:158,12: *No value for
argument 'action' in function call*
(*no-value-for-parameter*)*00:06:53.881* *E*:193,12: *No value for
argument 'action' in function call*
(*no-value-for-parameter*)*00:06:53.883* *E*:215,12: *No value for
argument 'action' in function call*
(*no-value-for-parameter*)*00:06:53.885* ************* Module
vdsm.virt.vm_migrate_hook*00:06:53.886* *E*:199, 4: *No value for
argument 'domain' in function call*
(*no-value-for-parameter*)*00:06:53.888* *E*:199, 4: *No value for
argument 'event' in function call*
(*no-value-for-parameter*)*00:06:53.890* *E*:199, 4: *No value for
argument 'phase' in function call*
(*no-value-for-parameter*)*00:06:53.892* ************* Module
vdsm.network.netlink.monitor*00:06:53.893* *E*:172,58: *Instance of
'closing' has no 'poll' member* (*no-member*)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20171212/293cae2b/attachment-0001.html>