[ovirt-devel] Introducing engine micro-benchmarks

Michal Skrivanek michal.skrivanek at redhat.com
Fri Mar 24 18:02:17 UTC 2017


> On 23 Mar 2017, at 11:37, Roy Golan <rgolan at redhat.com> wrote:
> 
> 
> 
> On Thu, Mar 23, 2017, 12:25 PM Martin Sivak <msivak at redhat.com <mailto:msivak at redhat.com>> wrote:
> Hi,
> 
> I am just wondering whether you tried Roman's Hystrix integration to
> see what command was so slow?
> 
> Martin
> 
> More on that in a different thread. Using only the debug logs it was quite easy to see that it was 13000+ queries to the db instead of one.

which thread?

> 
> On Thu, Mar 23, 2017 at 11:05 AM, Roy Golan <rgolan at redhat.com <mailto:rgolan at redhat.com>> wrote:
> > Lately we came across an interesting case where multi-host+mult-networks
> > resulted editing a host to conclude in minutes. One assumption that was
> > raised which we wanted to eliminate was that the decryption we perform on a
> > fence agent password might be taking too long.
> >
> > So these days it's an easy task thanks to JMH[1], supplied by the jdk
> > itself. I kickstarted [2] and added a 'DecryptionBenchmark', see the output
> > as an example[3]
> >
> > Although The JMH project recommends to create a separate project I find it
> > would be less trivial to people to contribute benchmarks let alone just
> > playing around with current code they want to test.
> >
> > - So, (when it will be merged) you add your benchmark under
> >  backend/manager/modules/benchmarks/MyBenchmark.java
> >
> > - run it from intellij using the jmh plugin exactly like a unit-test
> > OR
> > - mvn test -P benchmarks -pl org.ovirt.engine:benchmarks
> > OR
> > - java -jar benchmarks.jar
> >
> > I hope this would serve all of us well, please review and add your
> > benchmarks.
> >
> > PS - this will not run in the CI atm.
> >
> > [1] http://openjdk.java.net/projects/code-tools/jmh/ <http://openjdk.java.net/projects/code-tools/jmh/>
> > [2] https://gerrit.ovirt.org/74537 <https://gerrit.ovirt.org/74537> microbenchmarks: Introduce
> > microbenchmarks using JMH
> > [3] DecryptionBenchmark output (short version):
> >
> > # Run complete. Total time: 00:09:06
> >
> > Benchmark                             Mode  Samples    Score  Score error
> > Units
> > b.DecryptionBenchmark.decryption     thrpt       50  101.258        1.270
> > ops/s
> > b.DecryptionBenchmark.encryption     thrpt       50  238.587        4.667
> > ops/s
> > b.DecryptionBenchmark.decryption      avgt       50    0.010        0.000
> > s/op
> > b.DecryptionBenchmark.encryption      avgt       50    0.004        0.000
> > s/op
> > b.DecryptionBenchmark.decryption    sample     5544    0.010        0.000
> > s/op
> > b.DecryptionBenchmark.encryption    sample    13067    0.004        0.000
> > s/op
> > b.DecryptionBenchmark.decryption        ss       50    0.014        0.001
> > s
> > b.DecryptionBenchmark.encryption        ss       50    0.009        0.001
> > s
> >
> > Process finished with exit code 0
> >
> >
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org <mailto:Devel at ovirt.org>
> > http://lists.ovirt.org/mailman/listinfo/devel <http://lists.ovirt.org/mailman/listinfo/devel>
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170324/2e53cf64/attachment-0001.html>


More information about the Devel mailing list