[ovirt-devel] [VDSM] Adding Pylint to 'check' target

Nir Soffer nsoffer at redhat.com
Mon May 15 17:47:00 UTC 2017


Thanks everyone involved in the pylint effort, merged.

On Mon, May 15, 2017 at 7:59 PM Adam Litke <alitke at redhat.com> wrote:

> I like the current structure of the make check rule which has in
> increasing number of sub-targets (pep8, pyflakes, tests, etc) so it is
> still easy to run individual targets if the check rule is more than you
> need.  For me adding this is a big +1.
>
> On Mon, May 15, 2017 at 12:04 PM, Dan Kenigsberg <danken at redhat.com>
> wrote:
>
>> On Mon, May 15, 2017 at 4:47 PM, Fred Rolland <frolland at redhat.com>
>> wrote:
>> > Hi,
>> >
>> > We are introducing Pylint to be performed as part of the 'check' target.
>> > Once that patch [1] will be merged, every execution of 'make check' will
>> > include also a Pylint analysis.
>> >
>> > Note that execution time will be longer by about 2 minutes.
>> >
>> > However, you are can use 'jobs' flag to tell 'make' to execute recipes
>> > simultaneously.
>> > Be aware that the output of the jobs will be interleaved.
>> >
>> > For example, running 'make' with two parallel jobs:
>> >
>> >      make --jobs=2 check
>> >
>> > Regards,
>> > Freddy
>> >
>> > [1] https://gerrit.ovirt.org/#/c/76390/
>>
>> I'm a not as frequent user of `make check` as I used to be, but I'm
>> cool with this addition. I'd like to hear if others are bothered.
>>
>> Dan.
>>
>
>
>
> --
> Adam Litke
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170515/9c66fb84/attachment-0001.html>


More information about the Devel mailing list