[ovirt-devel] Why do we recommend to send a patch initially as draft?

Roy Golan rgolan at redhat.com
Mon Sep 18 19:42:04 UTC 2017


On Mon, 18 Sep 2017 at 22:30 Yaniv Kaul <ykaul at redhat.com> wrote:

> Here[1]:
> "Anyone can send a patch
> Initially a patch should be sent as draft"
>
> A draft is hidden from the public, why is it better to send as such?
>

I see few advantages and they all drawn from the assumption the initial
patchset is always some sort of work in progress in really most of the
cases:
1. It doesn't invoke automation and waste resources. First the developer
should run it and be passed the checkstyle/pep/other errors locally.
2. Default reviewers feature hopefully will put the reviewers in place
automatically so it not hidden.
3. After the patch is bit more mature it is worth publishing to get more
reviews. Half baked or controversial patches may be costly to review. After
they are published the reviewer can expect higher quality and can estimate
better the effort in review

IMHO we don't use this practice enough.

TIA,
> Y.
>
> [1] https://www.ovirt.org/develop/dev-process/working-with-gerrit/
> _______________________________________________
> Devel mailing list
> Devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170918/31020f08/attachment.html>


More information about the Devel mailing list