[ovirt-devel] Building the oVirt Engine master branch fails due to isort, python issues

[Steven Rosenberg]

Dear Martin Perina,

We found some issues with the oVirt Engine master branch when updating the
version via git pull.

We then performed the make command:

make clean install-dev PREFIX=~/ovirt_engine_master
DEV_BUILD_SCL_POSTGRESQL=1

It seems a new dependency was added for isort, so the make fails with the
following error:

--------------------------------------------------------------------------------------------------------------------

packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:313:21:
E126 continuation line over-indented for hanging indent
packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:314:21:
E126 continuation line over-indented for hanging indent
packaging/setup/plugins/ovirt-engine-common/base/core/duplicated_constants_check.py:109:17:
E124 closing bracket does not match visual indentation
+ ret=1
+ which isort
+ echo 'WARNING: tool '\''isort'\'' is missing'
WARNING: tool 'isort' is missing
+ exit 1
make[1]: *** [validations] Error 1
make[1]: Leaving directory `/home/srosenbe/Documents/git/ovirt-engine'
make: *** [all-dev] Error 2

--------------------------------------------------------------------------------------------------------------------

To attempt to address this issue, we guessed and installed python2-isort
through yum, though the readme states it is optional.

Though the process continued, it then failed in the python module:

/home/srosenbe/Documents/git/ovirt-engine/packaging/pythonlib/ovirt_engine/service.py

That error is here:

---------------------------------------------------------------------------------------------------------------------------


---
/home/srosenbe/Documents/git/ovirt-engine/packaging/pythonlib/ovirt_engine/service.py:before
2018-02-12 12:17:26
+++
/home/srosenbe/Documents/git/ovirt-engine/packaging/pythonlib/ovirt_engine/service.py:after
2018-02-26 12:07:11.233915
@@ -31,6 +31,7 @@
 import time

 import daemon
+

 from dateutil import tz

+ exit 1
make[1]: *** [validations] Error 1
make[1]: Leaving directory `/home/srosenbe/Documents/git/ovirt-engine'
make: *** [all-dev] Error 2

---------------------------------------------------------------------------------------------------------------------------

Please advise if you have a quick fix or when this issue will be addressed.

Thank you for your time and consideration.

With Best Regards.

Steven Rosenberg.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20180226/b837ae8b/attachment-0001.html>