<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr 4, 2014 at 3:15 PM, Itamar Heim <span dir="ltr"><<a href="mailto:iheim@redhat.com" target="_blank">iheim@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">On 04/04/2014 04:30 AM, Liran Zelkha wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">
<br>
<br>
<br>
On Thu, Apr 3, 2014 at 8:40 PM, Gilad Chaplik <<a href="mailto:gchaplik@redhat.com" target="_blank">gchaplik@redhat.com</a><br></div><div class="">
<mailto:<a href="mailto:gchaplik@redhat.com" target="_blank">gchaplik@redhat.com</a>>> wrote:<br>
<br>
----- Original Message -----<br>
> From: "Liran Zelkha" <<a href="mailto:liran.zelkha@gmail.com" target="_blank">liran.zelkha@gmail.com</a><br></div><div class="">
<mailto:<a href="mailto:liran.zelkha@gmail.com" target="_blank">liran.zelkha@gmail.com</a><u></u>>><br>
> To: "Gilad Chaplik" <<a href="mailto:gchaplik@redhat.com" target="_blank">gchaplik@redhat.com</a><br></div><div class="">
<mailto:<a href="mailto:gchaplik@redhat.com" target="_blank">gchaplik@redhat.com</a>>><br>
> Cc: "Omer Frenkel" <<a href="mailto:ofrenkel@redhat.com" target="_blank">ofrenkel@redhat.com</a><br></div><div class="">
<mailto:<a href="mailto:ofrenkel@redhat.com" target="_blank">ofrenkel@redhat.com</a>>>, "Eli Mesika" <<a href="mailto:emesika@redhat.com" target="_blank">emesika@redhat.com</a><br>
<mailto:<a href="mailto:emesika@redhat.com" target="_blank">emesika@redhat.com</a>>>, "engine-devel" <<a href="mailto:engine-devel@ovirt.org" target="_blank">engine-devel@ovirt.org</a><br>
<mailto:<a href="mailto:engine-devel@ovirt.org" target="_blank">engine-devel@ovirt.org</a><u></u>>>,<br>
> <a href="mailto:devel@linode01.ovirt.org" target="_blank">devel@linode01.ovirt.org</a> <mailto:<a href="mailto:devel@linode01.ovirt.org" target="_blank">devel@linode01.ovirt.<u></u>org</a>><br>
> Sent: Thursday, April 3, 2014 7:51:39 PM<br>
> Subject: Re: [Engine-devel] vds_dynamic refactor<br>
><br>
> On Thu, Apr 3, 2014 at 5:33 PM, Gilad Chaplik<br></div><div class="">
<<a href="mailto:gchaplik@redhat.com" target="_blank">gchaplik@redhat.com</a> <mailto:<a href="mailto:gchaplik@redhat.com" target="_blank">gchaplik@redhat.com</a>>> wrote:<br>
><br>
> > *From: *"Liran Zelkha" <<a href="mailto:liran.zelkha@gmail.com" target="_blank">liran.zelkha@gmail.com</a><br></div>
<mailto:<a href="mailto:liran.zelkha@gmail.com" target="_blank">liran.zelkha@gmail.com</a><u></u>>><div class=""><br>
> > *To: *"Gilad Chaplik" <<a href="mailto:gchaplik@redhat.com" target="_blank">gchaplik@redhat.com</a><br></div>
<mailto:<a href="mailto:gchaplik@redhat.com" target="_blank">gchaplik@redhat.com</a>>><div class=""><br>
> > *Cc: *"Omer Frenkel" <<a href="mailto:ofrenkel@redhat.com" target="_blank">ofrenkel@redhat.com</a><br></div>
<mailto:<a href="mailto:ofrenkel@redhat.com" target="_blank">ofrenkel@redhat.com</a>>>, "Eli Mesika" <<br>
> > <a href="mailto:emesika@redhat.com" target="_blank">emesika@redhat.com</a> <mailto:<a href="mailto:emesika@redhat.com" target="_blank">emesika@redhat.com</a>>>, "engine-devel"<br>
<<a href="mailto:engine-devel@ovirt.org" target="_blank">engine-devel@ovirt.org</a> <mailto:<a href="mailto:engine-devel@ovirt.org" target="_blank">engine-devel@ovirt.org</a><u></u>>><div class=""><br>
> > *Sent: *Thursday, April 3, 2014 5:27:56 PM<br>
> > *Subject: *Re: [Engine-devel] vds_dynamic refactor<br>
> ><br>
> > True but that's no reason to have a bad schema<br>
> ><br>
> > I'm open to new ideas and truly want to understand what is bad?<br>
> ><br>
> The problem is with both updates and selects.<br>
> For selects - to get all the information for the VDS we have multiple<br>
> joins. Adding another one will hurt performance even more.<br>
<br>
What about creating the VDS list in the db. i.e. your patch [1]<br>
about constructing VDS objects in the engine, should occur in the db<br>
within a SP, and should be transparent to the server. that will<br>
solve the multiple table join.<br>
<br>
<br>
The joins are happening on the server. We have a VDS view that brings in<br>
information from many tables and we retrieve rows from it all the time.<br>
Just run an explain on a select * from vds and see for yourself.<br>
</div></blockquote>
<br>
thought the distinction was vds_static is updated by user (configuration), where as vds_dyanmic/statistics is reported from vdsm (slow/fast updates).<br>
<br></blockquote><div>True - vds_static hardly change. But vds_dynamic is split-brain - it has practically static data, but also has the status - which changes rapidly. And since we have 3 tables, we need to do 3 joins to get VDS (actually we do much more). </div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
please remember joining them to one table, also means DWH will ETA all of data each time. today it will only copy statistics if dynamic did not change.<br>
<br>
</blockquote></div>I'm not saying joining all 3 tables to 1 table, just make them 2 tables. And since the data is hardly changing - same logic of DWH will stay. </div></div>