<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Apr 6, 2014 at 3:18 PM, Gilad Chaplik <span dir="ltr"><<a href="mailto:gchaplik@redhat.com" target="_blank">gchaplik@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">----- Original Message -----<br>
> From: "Itamar Heim" <<a href="mailto:iheim@redhat.com">iheim@redhat.com</a>><br>
> To: "Liran Zelkha" <<a href="mailto:liran.zelkha@gmail.com">liran.zelkha@gmail.com</a>><br>
</div><div class="">> Cc: "Gilad Chaplik" <<a href="mailto:gchaplik@redhat.com">gchaplik@redhat.com</a>>, <a href="mailto:devel@linode01.ovirt.org">devel@linode01.ovirt.org</a>, "engine-devel" <<a href="mailto:engine-devel@ovirt.org">engine-devel@ovirt.org</a>><br>
> Sent: Sunday, April 6, 2014 11:33:12 AM<br>
> Subject: Re: [Engine-devel] vds_dynamic refactor<br>
><br>
</div><div><div class="h5">> On 04/06/2014 11:32 AM, Liran Zelkha wrote:<br>
> ><br>
> ><br>
> ><br>
> > On Sun, Apr 6, 2014 at 11:22 AM, Itamar Heim <<a href="mailto:iheim@redhat.com">iheim@redhat.com</a><br>
> > <mailto:<a href="mailto:iheim@redhat.com">iheim@redhat.com</a>>> wrote:<br>
> ><br>
> > On 04/03/2014 07:51 PM, Liran Zelkha wrote:<br>
> ><br>
> > The problem is with both updates and selects.<br>
> > For selects - to get all the information for the VDS we have<br>
> > multiple<br>
> > joins. Adding another one will hurt performance even more.<br>
> > For updates - we have vds_static thats hardly changed.<br>
> > vds_statistics<br>
> > that changes all the time. vds_dynamic is not changed allot - but<br>
> > is<br>
> > updated all the time because of the status. I think it's best to<br>
> > split<br>
> > it to the two existing tables (BTW - relevant for VM as well)<br>
> ><br>
> ><br>
> > but we don't update it unless the status has changed, which is a<br>
> > rare occurance?<br>
> ><br>
> > Actually - no. We can definitely see times we are updating vds_dynamic<br>
> > with no reason at all. I tried to create patches for that - but it<br>
> > happens from many different places in the code.<br>
><br>
> what would be updated vds_dyanmic for status not originating in update<br>
> run time info?<br>
<br>
</div></div>We have separate DB flows for that (updateStatus and updatePartialVdsDynamicCalc and more in VdsDynamicDAODbFacadeImpl).<br>
A question: do you know if we update status in updateVdsDynamic? :-) not sure but I found a possible race for pending resources (cpu, mem), LOL :-)<br>
<br></blockquote><div>I think we do but not sure. Will check.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Still holds my original thought for having vds_on_boot. <br></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
><br>
</blockquote></div>Let's talk f2f on Tuesday?</div></div>