<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body ><div><br></div><div>Thanks Juan for the comments. I would update the wiki accordingly and send for confirmation.</div><div><br></div><div>Regards</div><div>Shubhendu</div><div><br></div><div><div style="font-size:75%;color:#575757">Sent from Samsung Mobile</div></div><br><br><br>-------- Original message --------<br>From: Juan Hernández <jhernand@redhat.com> <br>Date: 09/12/2014 18:51 (GMT+05:30) <br>To: Shubhendu Tripathi <shtripat@redhat.com>,devel@ovirt.org,Michael Pasternak <mpastern@redhat.com> <br>Subject: Re: [ovirt-devel] Gluster Volume Snapshots - Feature review <br> <br><br>On 12/04/2014 07:11 PM, Shubhendu Tripathi wrote:<br>> Hi Juan/Michael,<br>> <br>> This is a gentle reminder for the review of the REST api design for the <br>> below feature.<br>> We would be starting the REST development for the same soon (probably by <br>> Dec 2014 end).<br>> <br>> If there are specific comments, please pass it on. If no comments we <br>> would go ahead with the current design and implement accordingly.<br>> <br>> Request your time for this.<br>> <br>> Thanks and Regards,<br>> Shubhendu<br>> <br>> On 11/10/2014 12:22 PM, Shubhendu Tripathi wrote:<br>>> Hi All,<br>>><br>>> Please help us to review the design of Gluster Volume Snapshots in oVirt,<br>>><br>>> Here are two design on wiki page<br>>><br>>> General Feature Design<br>>> http://www.ovirt.org/Features/GlusterVolumeSnapshots<br>>><br>>> Detailed Design<br>>> http://www.ovirt.org/Features/Design/GlusterVolumeSnapshots<br>>><br>>> We target it in ovirt 3.6 release.<br>>><br>>> Marked Juan/Michael specifically for REST review.<br>>><br>>> Best Regards,<br>>> Shubhendu Tripathi<br><br>My comments about the RESTAPI:<br><br>1. You can't use the "snapshot" and "snapshots" XML elements, as those<br>are already in use for disk snapshots, and we don't have name space<br>support in the RESTAPI. You will have to use something different, for<br>example "gluster_volume_snapshots" and "gluster_volume_snapshot".<br><br>2. When adding a volume snapshot the name of the volume shouldn't be a<br>parameter, as that is implicit. Only the name and description of the<br>snapshot should be provided.<br><br>3. The operation to delete a snapshot should be performed on the<br>snapshot resource, not on the collection:<br><br> DELETE<br>/clusters/{cluster:id}/glustervolumes/{volume:id}/snapshots/{snapshot:id}<br><br>Ideally this operation shouldn't receive any parameters (thus no body).<br>If it does require parameters then they should be contained inside an<br>"action" element.<br><br>4. The operation to update the snapshot configuration should be the PUT<br>operation of the volume, not a new "snapshotconfig" sub-resource, as<br>these kind of sub-resources aren't well supported by the SDKs and the CLI.<br><br>-- <br>Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta<br>3ºD, 28016 Madrid, Spain<br>Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.<br></body>