<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 31, 2015 at 9:06 AM, Michal Skrivanek <span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
On Jul 31, 2015, at 08:08 , Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>> wrote:<br>
<br>
> Hi,<br>
> vdsm from 3.5 branch is currently failing to build on Fedora, failing pep8.<br>
> Please fix ASAP.<br>
><br>
> Fedora 20: <a href="http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/288/artifact/exported-artifacts/build.log" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/288/artifact/exported-artifacts/build.log</a><br>
> Fedora 21: <a href="http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/114/artifact/exported-artifacts/build.log" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/114/artifact/exported-artifacts/build.log</a><br>
<br>
</span>looks like [1] merged 3 weeks ago<br>
<br>
hm..running CI on merged patches doesn't alert on failure?<br></blockquote><div><br></div><div><br></div><div>Looks like no email is triggered on failure since jenkins already comment on gerrit and gerrit send an email to all people reviewing the patch.</div><div>So all of them have been warned that the patch was failing on merge.</div><div><br></div><div>I think vdsm is also missing a pep8 / pyflakes validation on patch sent, it would help avoiding to discover the issue after having merged the patch.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks,<br>
michal<br>
<br>
[1] <a href="https://gerrit.ovirt.org/#/c/43276/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/43276/</a><br>
<span class=""><br>
><br>
><br>
> --<br>
> Sandro Bonazzola<br>
> Better technology. Faster innovation. Powered by community collaboration.<br>
> See how it works at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a><br>
</span>> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a><br></div></div></div></div>
</div></div>