<div dir="ltr"><div>The findbugs failure is related to patch set 1, which was previously was marked by Jenkins as +1. If that wasn't +1'ed, we would've wait until Jenkins job is finished, but since it has +1 we were under impression that the patch is OK.<br></div>Looks like findbugs job was triggered by Verified+1, whereas test were run upon patch set upload. IMHO the split between the jobs makes their behavior misleading.<br>BTW, what was merged is patch set 2, which wasn't checked by findbugs at all. <br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 12, 2015 at 3:42 PM, David Caro <span dir="ltr"><<a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 08/12, Yevgeny Zaspitsky wrote:<br>
> My bad, sorry. The findbugs job runs indeed.<br>
><br>
> However look at that patch <a href="https://gerrit.ovirt.org/#/c/44604/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/44604/</a> .<br>
> Patch set 1 got Continuous-Integration+1 from Jenkins after running unit<br>
> tests and then, much later,<br>
<br>
</span>That much later is after merge, the findbugs ran once the patch was merged. You<br>
should understand that each event triggers a tests run, and for each tests run<br>
you get only one review. In this case the tests that check the code when you<br>
send the patch passed, but the ones that check the code after it's merged<br>
failed.<br>
<div><div class="h5"><br>
<br>
> Jenkins changed its mind and gave -1 after<br>
> findbugs job has finished.<br>
> IMHO that's is a misleading behavior.<br>
><br>
> Regards,<br>
> Yevgeny<br>
><br>
> On Wed, Aug 12, 2015 at 12:12 PM, Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>><br>
> wrote:<br>
><br>
> ><br>
> ><br>
> > On Tue, Aug 11, 2015 at 6:13 PM, Yevgeny Zaspitsky <<a href="mailto:yzaspits@redhat.com">yzaspits@redhat.com</a>><br>
> > wrote:<br>
> ><br>
> >> Hi All,<br>
> >><br>
> >> Seems like recently Jenkins has stopped running findbugs check on the<br>
> >> patches before they get merged into master. Although that could save some<br>
> >> Jenkins resources and make the its reaction faster, that makes the<br>
> >> integration (with master) check less effective.<br>
> >><br>
> >> Was that done on purpose? Can that be restored for master patches?<br>
> >><br>
> >><br>
> > AFAIK findbugs is still up and running:<br>
> > <a href="http://jenkins.ovirt.org/search/?q=find-bugs" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/search/?q=find-bugs</a><br>
> > Have you any specific patch as example?<br>
> ><br>
> ><br>
> ><br>
> ><br>
> >> Regards,<br>
> >> Yevgeny<br>
> >><br>
> >> _______________________________________________<br>
> >> Devel mailing list<br>
> >> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> >> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> >><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > Sandro Bonazzola<br>
> > Better technology. Faster innovation. Powered by community collaboration.<br>
> > See how it works at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a><br>
> ><br>
<br>
</div></div>> _______________________________________________<br>
> Infra mailing list<br>
> <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
David Caro<br>
<br>
Red Hat S.L.<br>
Continuous Integration Engineer - EMEA ENG Virtualization R&D<br>
<br>
Tel.: <a href="tel:%2B420%20532%20294%20605" value="+420532294605">+420 532 294 605</a><br>
Email: <a href="mailto:dcaro@redhat.com">dcaro@redhat.com</a><br>
Web: <a href="http://www.redhat.com" rel="noreferrer" target="_blank">www.redhat.com</a><br>
RHT Global #: 82-62605<br>
</font></span></blockquote></div><br></div>