<div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Einav,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Thank you very much for your explanation.</div><div class="gmail_default" style="font-size:small">I posted the question #41 before reading your reply.</div><div class="gmail_default" style="font-size:small">When this is resolve, #41 should be resolved at the same time.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">@<div class="gmail_default" style="display:inline"></div>Eliraz,</div><div class="gmail_default" style="font-size:small">It would be great if you could get back to us by tomorrow.</div><div class="gmail_default" style="font-size:small">Many thanks in advance.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Kind regards,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Yuko</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_extra"><div class="gmail_quote">On Wed, Nov 25, 2015 at 7:01 AM, Einav Cohen <span dir="ltr"><<a href="mailto:ecohen@redhat.com" target="_blank">ecohen@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Yuko,<br>
<br>
[adding <div class="gmail_default" style="font-size:small;display:inline"></div>Eliraz, patch [1] author to confirm the below]<br>
<br>
Yes, from looking at the patch, it seems that the idea is to guide<br>
the user to provide a space-separated *list* of "< key >=< value >"<br>
strings.<br>
<br>
BTW, pointing out that this string does not appear as a standalone<br>
text, but as a suffix of another message.<br>
<br>
Note the following texts in the UIMessages document:<br>
<br>
- "This field should be in the format of: {0}"<br>
[resource ID: customPropertiesValuesShouldBeInFormatReason]<br>
<br>
- "This field can be empty or contain a {0}"<br>
[resource ID: emptyOrValidKeyValueFormatMessage]<br>
<br>
The "< key >=< value > separated with space" text can appear as<br>
one of the options for the "{0}" placeholders in the messages above.<br>
So the possible full strings would ultimately be:<br>
<br>
- "This field should be in the format of: < key >=< value > separated with space"<br>
<br>
- "This field can be empty or contain a < key >=< value > separated with space"<br>
<br>
Localizing sentence "particles" is not a good practice, as grammatical<br>
rules of different locales may not allow to translate those particles<br>
easily.<br>
It is always best to work with full sentences, rather than sentence<br>
particles, even at the cost of less optimal / elegant code.<br>
<br>
@Eliraz: I would recommend to:<br>
<br>
- add a "list" notion in the messages; right now, since the word "list"<br>
is not mentioned in the messages, it seems like a valid value would be<br>
just a single key-value pair (i.e. "a=b" seems legal, "a=b c=d" seems<br>
illegal, although it is actually legal).<br>
<br>
- change "< key >=< value >" to "[key]=[value]"<br>
(the spaced "< >" are a bit confusing).<br>
<br>
- change the code to use full sentences. I would simply work with two<br>
separate messages, such as:<br>
<br>
* This field should contain a space-separated list of "[key]=[value]" strings.<br>
<br>
* This field should be empty or contain a space-separated list of "[key]=[value]" strings.<br>
<br>
----<br>
Thanks,<br>
Einav<br>
<br>
[1] <a href="https://gerrit.ovirt.org/#/c/45366" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/45366</a><br>
<br>
----- Original Message -----<br>
> From: "Yuko Katabami" <<a href="mailto:ykatabam@redhat.com" target="_blank">ykatabam@redhat.com</a>><br>
> To: <a href="mailto:devel@ovirt.org" target="_blank">devel@ovirt.org</a><br>
> Sent: Tuesday, November 24, 2015 1:35:45 AM<br>
> Subject: [ovirt-devel] [oVirt 3.6 Localization Question #38] "< key >=< value > separated with space"<br>
><br>
> Hello again,<br>
><br>
> I have another question I would like to ask for your help:<br>
><br>
> File: uicompat.UIMessages<br>
> Resource ID: keyValueFormat<br>
> String: < key >=< value > separated with space<br>
> Question : Is this asking user to provide a space-separated list of multiple<br>
> "< key >=< value >" values?<br>
><br>
> Kind regards,<br>
><br>
> Yuko<br>
><br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
</blockquote></div><br><br clear="all"><div><br></div>
</div></div>