<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 9, 2015 at 12:15 PM, David Caro <span dir="ltr"><<a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>On 12/09 12:00, Amit Aviram wrote:<br>
> On Wed, Dec 9, 2015 at 11:37 AM, Barak Korren <<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a>> wrote:<br>
><br>
> > >>> > [1]: <a href="http://www.ovirt.org/CI/Build_and_test_standards" rel="noreferrer" target="_blank">http://www.ovirt.org/CI/Build_and_test_standards</a><br>
> > >>> ><br>
> > ><br>
> > > That's nice, but most of us are not aware of all that..<br>
> > ><br>
> ><br>
> > Well, we can do a better job advocating that, I try to mention this<br>
> > almost in any infra/devel thread where 'CI' is mentioned.<br>
> > I'm open to suggestions about how to make developers more aware of the<br>
> > fact that the ultimate power to determine what happens in CI had<br>
> > mostly been placed in their hands...<br>
><br>
><br>
> What I'm offering is not letting us a choice, exactly because what you are<br>
> saying regarding the fact that most of the influence of what happens in CI<br>
> is in our hands. otherwise what happens is the current situation where<br>
> some/most of the developers are not aware of their options, or misses the<br>
> mails or whatever..<br>
><br>
><br>
> > ><br>
> > > From what I'm seeing, most of the developers here don't make their<br>
> > patches<br>
> > > drafts.. moreover,<br>
> > > - personally I didn't even know that it will not trigger jobs if it is a<br>
> > > draft. (and I'm not the only one)<br>
> ><br>
> > Well, now you know... Adding 'devel' with hope more devs will read this.<br>
> ><br>
> > > - sometimes I need to label my patches, therefor can't make it a draft<br>
> > ><br>
> > By 'label' you mean set topic?<br>
> > Not sure those are mutually exclusive, 'git review' options seem to<br>
> > indicate they are not. I will look deeper into that.<br>
> ><br>
> > > nowadays we are waiting for the jobs too much to finish. and the reality<br>
> > is<br>
> > > that too much jobs shouldn't run at all- despite all of the nice things<br>
> > you<br>
> > > guys show here..<br>
> ><br>
> > I which cases besides the patch not being "ready" (=draft...) should<br>
> > jobs not run?<br>
> ><br>
><br>
> Most of the review process doesn't need the jobs to run. a patch has 5-10,<br>
> and sometimes much more sets until it is being merged- you don't need to<br>
> run the jobs every single time you are updating your patch..<br>
><br>
><br>
> ><br>
> > ><br>
> > > I still think that it will be a better solution to force the developer to<br>
> > > activate the tests manually (by adding a flag when pushing or even doing<br>
> > it<br>
> > > with the jenkins client..)<br>
> > ><br>
> > We tried to add the 'workflow' flag for that at some point (It is used<br>
> > by most infra projects), but it was not accepted with any enthusiasm<br>
> > by the devs, you can search back the discussion on 'devel'.<br>
><br>
><br>
> The workflow makes job DISABLING optional.<br>
> I'm suggesting making job ENABLING optional, with some other flag..<br>
> As we must run it to merge- it won't be missed, and will be triggered only<br>
> when needed.<br>
<br>
</div></div>That's not true, the workflow make job enabling optional, if you don't set it,<br>
it will not run<br></blockquote><div><br></div><div>So I think we should use it :) </div><div>Why was it rejected? </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
><br>
><br>
><br>
> ><br>
> > --<br>
> > Barak Korren<br>
> > <a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a><br>
> > RHEV-CI Team<br>
> ><br>
<br>
</span><span>> _______________________________________________<br>
> Infra mailing list<br>
> <a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/infra</a><br>
<br>
<br>
--<br>
</span><div><div>David Caro<br>
<br>
Red Hat S.L.<br>
Continuous Integration Engineer - EMEA ENG Virtualization R&D<br>
<br>
Tel.: <a href="tel:%2B420%20532%20294%20605" value="+420532294605" target="_blank">+420 532 294 605</a><br>
Email: <a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a><br>
IRC: dcaro|dcaroest@{freenode|oftc|redhat}<br>
Web: <a href="http://www.redhat.com" rel="noreferrer" target="_blank">www.redhat.com</a><br>
RHT Global #: 82-62605<br>
</div></div></blockquote></div><br></div></div>