<div dir="ltr">Acked, let me know if you need me to merge</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 15, 2015 at 12:36 PM, Tomas Jelinek <span dir="ltr"><<a href="mailto:tjelinek@redhat.com" target="_blank">tjelinek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
----- Original Message -----<br>
> From: "Tal Nisan" <<a href="mailto:tnisan@redhat.com">tnisan@redhat.com</a>><br>
> To: "Sandro Bonazzola" <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>>, "Einav Cohen" <<a href="mailto:ecohen@redhat.com">ecohen@redhat.com</a>><br>
> Cc: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
</span><span class="">> Sent: Tuesday, December 15, 2015 11:29:17 AM<br>
> Subject: Re: [ovirt-devel] [ACTION REQUIRED] ovirt-engine build failing on master<br>
><br>
</span><span class="">> Einav, it seems like an old issue we had when the default message contains<br>
> the necessary placeholders but since no translations patch was released yet<br>
> we don't have the placeholders in the translated messages, did we decide on<br>
> a workaround back then?<br>
<br>
</span>This particular issue is only happening when you change a message which has already been in localized property files<br>
in a way that you change the num of parameters of it.<br>
<br>
This fixes it: <a href="https://gerrit.ovirt.org/#/c/50506/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/50506/</a><br>
Tested with 2 locales and seems to be working - Tal, adding you as a reviewer since you are already in the thread ;)<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> On Tue, Dec 15, 2015 at 12:04 PM, Sandro Bonazzola < <a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a> ><br>
> wrote:<br>
><br>
><br>
><br>
> 05:22:42 [INFO] [ERROR] Required argument 3 not present:<br>
> {0} ({1} Sockets, {2} Kerne pro Socket) 05:22:42 [INFO] [ERROR] Errors in<br>
> 'org/ovirt/engine/ui/uicompat/ConstantsManager.java' 05:22:42 [INFO]<br>
> [ERROR] Line 38: Failed to resolve<br>
> 'org.ovirt.engine.ui.uicompat.UIMessages' via deferred binding<br>
><br>
> See<br>
> <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/682/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/682/console</a><br>
><br>
> Please fix ASAP<br>
><br>
><br>
> --<br>
> Sandro Bonazzola<br>
> Better technology. Faster innovation. Powered by community collaboration.<br>
> See how it works at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a><br>
><br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
><br>
><br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
</div></div></blockquote></div><br></div>