<div dir="ltr">This is very useful information, thanks!<div>However, after making a quick browsing for this in our wiki pages- I wasn't able to find it anywhere.. How can we add it to the wiki? it should be easy located as it is very relevant for every vdsm developer..</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 29, 2015 at 7:10 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Dec 29, 2015 at 7:04 PM, Yaniv Kaul <<a href="mailto:ykaul@redhat.com">ykaul@redhat.com</a>> wrote:<br>
<span class="">> On Tue, Dec 29, 2015 at 6:29 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>> wrote:<br>
>><br>
>> Hi all,<br>
>><br>
>> Recently we added a new test, breaking make check when run on a<br>
>> development<br>
>> machine as non-privileged user.<br>
>> <a href="https://gerrit.ovirt.org/50984" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/50984</a><br>
>><br>
>> This test pass on the CI environment, because the tests are running as<br>
>> root.<br>
><br>
><br>
</span>> Should we do something different in CI?<br>
<br>
We should, but I want to discuss this in the devel mailing list.<br>
<br>
Nir<br>
<br>
> Y.<br>
<div class="HOEnZb"><div class="h5">><br>
>><br>
>><br>
>> Please verify that "make check" is successful on your development<br>
>> environment.<br>
>> otherwise, you may break the tests for others using this practice.<br>
>><br>
>><br>
>> Best practice for running the tests:<br>
>><br>
>> 1. Run the tests for the module you change:<br>
>><br>
>> $ ./run_tests_local.sh rwlock_test.py<br>
>> nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']<br>
>> rwlock_test.RWLockStressTests<br>
>> test_fairness(1, 2) SKIP:<br>
>> Stress tests are disabled<br>
>> test_fairness(2, 8) SKIP:<br>
>> Stress tests are disabled<br>
>> test_fairness(3, 32) SKIP:<br>
>> Stress tests are disabled<br>
>> test_fairness(4, 128) SKIP:<br>
>> Stress tests are disabled<br>
>> rwlock_test.RWLockTests<br>
>> test_concurrent_readers OK<br>
>> test_demotion_no_waiters OK<br>
>> test_demotion_with_blocked_reader SKIP:<br>
>> Slow tests are disabled<br>
>> test_demotion_with_blocked_writer SKIP:<br>
>> Slow tests are disabled<br>
>> test_exclusive_context_blocks_reader SKIP:<br>
>> Slow tests are disabled<br>
>> test_exclusive_context_blocks_writer SKIP:<br>
>> Slow tests are disabled<br>
>> test_fifo SKIP:<br>
>> Slow tests are disabled<br>
>> test_promotion_forbidden OK<br>
>> test_recursive_read_lock OK<br>
>> test_recursive_write_lock OK<br>
>> test_release_other_thread_read_lock OK<br>
>> test_release_other_thread_write_lock OK<br>
>> test_shared_context_allows_reader OK<br>
>> test_shared_context_blocks_writer SKIP:<br>
>> Slow tests are disabled<br>
>> test_wakeup_all_blocked_readers SKIP:<br>
>> Slow tests are disabled<br>
>> test_wakeup_blocked_reader SKIP:<br>
>> Slow tests are disabled<br>
>> test_wakeup_blocked_writer SKIP:<br>
>> Slow tests are disabled<br>
>><br>
>> ----------------------------------------------------------------------<br>
>> Ran 21 tests in 0.005s<br>
>><br>
>> This should be very fast and should run after every change.<br>
>><br>
>> 2. Check that slow and stress tests pass<br>
>><br>
>> Some modules have @slowtest and @stresstest, which are skipped by default.<br>
>> When modifying such modules, enable also these tests:<br>
>><br>
>> $ ./run_tests_local.sh rwlock_test.py --enable-slow-tests<br>
>> --enable-stress-tests<br>
>> nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']<br>
>> rwlock_test.RWLockStressTests<br>
>> test_fairness(1, 2) OK<br>
>> test_fairness(2, 8) OK<br>
>> test_fairness(3, 32) OK<br>
>> test_fairness(4, 128) OK<br>
>> rwlock_test.RWLockTests<br>
>> test_concurrent_readers OK<br>
>> test_demotion_no_waiters OK<br>
>> test_demotion_with_blocked_reader SKIP:<br>
>> Known issue in current code<br>
>> test_demotion_with_blocked_writer OK<br>
>> test_exclusive_context_blocks_reader OK<br>
>> test_exclusive_context_blocks_writer OK<br>
>> test_fifo OK<br>
>> test_promotion_forbidden OK<br>
>> test_recursive_read_lock OK<br>
>> test_recursive_write_lock OK<br>
>> test_release_other_thread_read_lock OK<br>
>> test_release_other_thread_write_lock OK<br>
>> test_shared_context_allows_reader OK<br>
>> test_shared_context_blocks_writer OK<br>
>> test_wakeup_all_blocked_readers OK<br>
>> test_wakeup_blocked_reader OK<br>
>> test_wakeup_blocked_writer OK<br>
>><br>
>> ----------------------------------------------------------------------<br>
>> Ran 21 tests in 14.054s<br>
>><br>
>> This may take more time.<br>
>><br>
>> 3. When the module tests pass, run "make check"<br>
>><br>
>> make check<br>
>><br>
>> This takes about 90 seconds.<br>
>><br>
>> To run all tests, including slow and stress tests, use:<br>
>><br>
>> make check-all<br>
>><br>
>> This may take couple of minutes, so it is not recommended.<br>
>><br>
>> Thanks,<br>
>> Nir<br>
>> _______________________________________________<br>
>> Devel mailing list<br>
>> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
>> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
><br>
><br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
</div></div></blockquote></div><br></div>