<p dir="ltr">This is amazing. Great work! </p>
<p dir="ltr">Yaniv Dary<br>
Technical Product Manager<br>
Red Hat Israel Ltd.<br>
34 Jerusalem Road<br>
Building A, 4th floor<br>
Ra'anana, Israel 4350109</p>
<p dir="ltr">Tel : +972 (9) 7692306<br>
8272306<br>
Email: <a href="mailto:ydary@redhat.com">ydary@redhat.com</a><br>
IRC : ydary</p>
<div class="gmail_quote">On Jan 13, 2016 01:00, "Eli Mesika" <<a href="mailto:emesika@redhat.com">emesika@redhat.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<br>
I have merged today this patch[1] to master.<br>
<br>
The code from historical reasons uses both "vds group" and "cluster" for a cluster entity.<br>
This makes the code not-clear, non-readable and hard for beginners (to find for example SPs that handle clusters , or all code related to a cluster operation)<br>
This also makes our logging and error messages using sometimes "vds group" and sometimes "cluster" to relate to the same entity.<br>
Worse than that, new code written sometimes introduce a mix of both terms.<br>
<br>
Patch[1] renames "vds group" to cluster all over the code.<br>
This renaming covers all engine code including<br>
Class names<br>
Variables<br>
Comments<br>
Logging<br>
Error messages<br>
Database tables,views, columns and SPs including all kinds of keys and constrains<br>
<br>
Please do not use from now on the term "vds group" (all its variants (VdsGroup, vdsGroup, vds_group etc.)<br>
Instead , cluster and all its variants should be used<br>
<br>
If you have some written code that is not merged yet, you will probably have a little work on rebase on top this patch, as far as I know those should be trivial patches and if you have any question, please ask.<br>
<br>
Possible affects on other products are minor and were communicated to the relevant product people.<br>
<br>
[1] <a href="https://gerrit.ovirt.org/#/c/51109/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/51109/</a><br>
<br>
Thanks<br>
Eli Mesika<br>
<br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
</blockquote></div>