<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 01/14/2016 08:26 AM, Moti Asayag
wrote:<br>
</div>
<blockquote
cite="mid:CAE26aYfOY56znTbFEH8ucnqP9VTqeumc4zWz55LLe6k5YnMBNg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Jan 13, 2016 at 5:17 PM,
Fabian Deutsch <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:fdeutsch@redhat.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:fdeutsch@redhat.com">fdeutsch@redhat.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hey,<br>
<br>
we've now merged a patch [0] to use and populate the
VARIANT and<br>
VARIANT_ID fields on Node.<br>
<br>
Currently the value is something like
"ovirt-node-$BRANCH", i.e.<br>
"ovirt-node-master" or "ovirt-node-3.6".<br>
<br>
I'd like to question if we should include the oVirt
version in the ID,<br>
or if we should just use "ovirt-node" without the version.<br>
<br>
From my POV the variant is not depending on a specific
version, that<br>
is why I'd like to discuss it.<br>
</blockquote>
</div>
</div>
</div>
</blockquote>
My point of view is that variant_id doesn't depend of specific
version, it only shows the <br>
'flavor' of distro and may or may not include numbers as the link
[1] showed. <br>
<br>
One benefit to have the branding/ovirt release in variant id is that
in the new oVirt Node<br>
it uses Cockpit which reads /etc/os-release (ID + VARIANT_ID ) to
show to the users in the login<br>
page such data, i.e: <br>
<br>
"CentOS oVirt Node 3.6" <br>
<br>
Username: <br>
Password: <br>
<br>
<blockquote
cite="mid:CAE26aYfOY56znTbFEH8ucnqP9VTqeumc4zWz55LLe6k5YnMBNg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
+1<br>
</div>
<div>I agree the variant-id should not be a version
specific. It should only describe the flavour of the host.<br>
</div>
<div>I don't see why the engine should be aware of the
specific version of it, especially since we'd like to have
a unified process for all host types and furthermore for
the same host type of different versions.<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
I agree that Engine shouldn't care about a specific version at all
but probably VDSM will be sending /etc/os-release to Engine for
displaying data to the users.<br>
<br>
<blockquote
cite="mid:CAE26aYfOY56znTbFEH8ucnqP9VTqeumc4zWz55LLe6k5YnMBNg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
The oVirt version can still be retieved like on any other
host i.e.<br>
using rpm or maybe some file(?).<br>
</blockquote>
<div><br>
</div>
<div> Resolving the supported version of the hypervisor
should be done the same way as for any host by monitoring
the capabilities as reported by VDSM.<br>
<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
- fabian<br>
<br>
--<br>
[0] <a moz-do-not-send="true"
href="https://gerrit.ovirt.org/gitweb?p=ovirt-release.git;a=blob;f=ovirt-release-master/ovirt-release-master.spec.in;h=8690d39402221acac402a6f2f0c485571ad838fa;hb=HEAD#l140"
rel="noreferrer" target="_blank">https://gerrit.ovirt.org/gitweb?p=ovirt-release.git;a=blob;f=ovirt-release-master/ovirt-release-master.spec.in;h=8690d39402221acac402a6f2f0c485571ad838fa;hb=HEAD#l140</a><br>
[1] <a moz-do-not-send="true"
href="http://www.freedesktop.org/software/systemd/man/os-release.html"
rel="noreferrer" target="_blank">http://www.freedesktop.org/software/systemd/man/os-release.html</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
<div class="gmail_signature">
<div dir="ltr">
<div>Regards,<br>
</div>
Moti<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>