<div dir="ltr">Hi guys,<div><br><div>Following the work to omit deathSignal attribute from our cpopen implementation we posted <a href="https://gerrit.ovirt.org/51407">https://gerrit.ovirt.org/51407</a> which is ready for use.</div><div>Currently locations that should use it are:</div><div>(I wrote above who I expect to check the area and post a patch for that - we'll discuss it during next vdsm-sync to follow the work)</div><div><br></div><div>shavivi:</div><div><div>vdsm/v2v.py - in _start_virt_v2v you return aysnProc that should call kill() on fail<br></div><div><br></div><div>fromani:</div><div>vdsm_hooks/checkimages/before_vm_start.py - in checkImage - the code looks ok, but check if not better to use the terminating decorator.. I think it will be nicer<br></div><div><br></div><div>nsoffer:</div><div>vdsm/storage/mount.py - good looks ok, I prefer to use terminator there</div><div>vdsm/storage/iscsiadm.py<br></div><div>vdsm/storage/imageSharing.py<br></div><div>vdsm/storage/hba.py -good handling, use terminator<br></div><div>vdsm/storage/blockSD.py<br></div><div><br></div><div>please check your usage with the returned process and see that you're not depending on deathSignal for it to die properly on crush</div><div><br></div><div>some places define deathSignal for no reason, the call is sync - please remove those places:</div><div><br></div><div>nsoffer:</div><div>lib/vdsm/qemuimg.py <br></div><div>vdsm/storage/curlImgWrap.py<br></div><div>vdsm/storage/storage_mailbox.py</div><div>vdsm/storage/misc.py<br></div><div><br></div><div>fromani:<br></div><div><div>lib/vdsm/virtsparsify.py<br></div><div><br></div><div>ybronhei:</div><div>vdsm/API.py</div></div><div><br></div><div><br></div><div>If you can't get to it in a reasonable time, add the task to the list [1] and someone else will be it up.</div><div>Please try to go over before the sync call.</div><div><br></div><div>[1] - <a href="https://docs.google.com/spreadsheets/d/180F-C1jU54ajUn7TuR-NwrKRZY1IiZI1Z8U5HWbvEvM/edit#gid=0">https://docs.google.com/spreadsheets/d/180F-C1jU54ajUn7TuR-NwrKRZY1IiZI1Z8U5HWbvEvM/edit#gid=0</a></div><div><br></div><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8px"><b>Yaniv Bronhaim.</b></span><br></div></div></div></div></div>
</div></div></div>