<div dir="ltr"><div><div><div><div>Juan,<br><br></div>Well done!<br><br>But, there is a mismatch between gerrit and gitub links in your e-mail.<br></div><br></div>Regards,<br></div>Yevgeny<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 7, 2016 at 5:15 PM, Juan Hernández <span dir="ltr"><<a href="mailto:jhernand@redhat.com" target="_blank">jhernand@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
The specification of the RESTAPI (a.k.a. the model) and the tools that<br>
process it (a.k.a. the metamodel) have been moved to separate git<br>
repositories:<br>
<br>
Model:<br>
git clone <a href="https://gerrit.ovirt.org/ovirt-engine-api-model" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/ovirt-engine-api-model</a><br>
<a href="https://github.com/oVirt/ovirt-engine-api-metamodel" rel="noreferrer" target="_blank">https://github.com/oVirt/ovirt-engine-api-metamodel</a><br>
<br>
Metamodel:<br>
git clone <a href="https://gerrit.ovirt.org/ovirt-engine-api-metamodel" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/ovirt-engine-api-metamodel</a><br>
<a href="https://github.com/oVirt/ovirt-engine-api-model" rel="noreferrer" target="_blank">https://github.com/oVirt/ovirt-engine-api-model</a><br>
<br>
Currently I'm manually keeping these repositories in sync with the<br>
ovirt-engine repository, but I will very soon remove all this code from<br>
the ovirt-engine repository:<br>
<br>
restapi: Move model to separate repository<br>
<a href="https://gerrit.ovirt.org/51519" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/51519</a><br>
<br>
This means that once the above patch is merged, which will be very soon,<br>
probably this week, when you need to do changes to the specification of<br>
the RESTAPI, you will need first to prepare a patch for the<br>
ovirt-engine-api-model, submit it, review it, etc. Once that patch is<br>
merged I will do a new release of the model. Then you will need to<br>
update the root POM of the engine to use the new version of the model,<br>
for example:<br>
<br>
- <model.version>4.0.1</model.version><br>
+ <model.version>4.0.2</model.version><br>
<br>
And adjust the engine to work with the new version of the model.<br>
<br>
As you will probably want to do these changes and test them before<br>
publishing anything, or asking for any review, I'd suggest the following<br>
process:<br>
<br>
1. Checkout the model project:<br>
<br>
$ git clone git://<a href="http://gerrit.ovirt.org/ovirt-engine-api-model" rel="noreferrer" target="_blank">gerrit.ovirt.org/ovirt-engine-api-model</a><br>
<br>
2. Check the version number in the root POM. It should be a SNAPSHOT<br>
version, unless you explicitly checkout from a tag. For example,<br>
currently it is 4.0.2-SNAPSHOT.<br>
<br>
3. Make your changes to the model, and then install it to your local<br>
Maven repository:<br>
<br>
$ mvn clean install<br>
<br>
4. Add to your $HOME/.m2/settings.xml a profile that is activated<br>
automatically and that changes the value of the "model.version" property<br>
used by the engine:<br>
<br>
<activeProfiles><br>
<activeProfile>myprofile</activeProfile><br>
</activeProfiles><br>
<br>
<profiles><br>
<profile><br>
<id>myprofile</id><br>
<properties><br>
<model.version>4.0.2-SNAPSHOT</model.version><br>
</properties><br>
</profile><br>
</profiles><br>
<br>
5. Make your changes to the engine, and build it as usual, it will your<br>
modified version of the model.<br>
<br>
6. Publish/review the changes to the model.<br>
<br>
7. Wait for the new model release.<br>
<br>
8. Publish/review the changes to the engine, including the change of the<br>
model version in the root POM. Note that you can publish/review these<br>
changes without waiting for the new model release, but the Jenkins test<br>
will fail.<br>
<br>
Note also that changes to the model will need to be properly documented<br>
in order to be accepted. There are some instructions on how to document<br>
the model here:<br>
<br>
<a href="https://github.com/oVirt/ovirt-engine-api-model/blob/master/README.md" rel="noreferrer" target="_blank">https://github.com/oVirt/ovirt-engine-api-model/blob/master/README.md</a><br>
<br>
All these changes affect only the master branch, nothing changed in<br>
these regards in the 3.6 branch.<br>
<br>
Regards,<br>
Juan Hernandez<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta<br>
3ºD, 28016 Madrid, Spain<br>
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.<br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a></font></span></blockquote></div><br></div>