<div dir="ltr">any updates about that?<div><br><div><a href="https://gerrit.ovirt.org/#/c/52357/">https://gerrit.ovirt.org/#/c/52357/</a> - this can be verified and get it</div><div><a href="https://gerrit.ovirt.org/#/c/52349/">https://gerrit.ovirt.org/#/c/52349/</a> - got tiny comment about unneeded kill call</div><div><a href="https://gerrit.ovirt.org/51407">https://gerrit.ovirt.org/51407</a> - Nir can merge</div><div><br><div>Nir - please review <a href="https://gerrit.ovirt.org/52646">https://gerrit.ovirt.org/52646</a> or take over</div></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">and update soon what the plans regarding the async usages in </div><div style="font-size:12.8px"><div style="font-size:12.8px">vdsm/storage/mount.py</div><div style="font-size:12.8px">vdsm/storage/iscsiadm.py<br></div><div style="font-size:12.8px">vdsm/storage/imageSharing.py<br></div><div style="font-size:12.8px">vdsm/storage/hba.py<br></div><div style="font-size:12.8px">vdsm/storage/blockSD.py</div><div style="font-size:12.8px">and v2v.py </div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">I prefer not to wait for that too long - we can remove the deathSignal usages there, and continue with <a href="https://gerrit.ovirt.org/#/c/48384">https://gerrit.ovirt.org/#/c/48384</a></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Please also check if you can take over the re-implementation of async proc (<a href="https://gerrit.ovirt.org/49441">https://gerrit.ovirt.org/49441</a>) as you (storage operations) are the main and only user of it, and it should fit Popen proc.</div><div style="font-size:12.8px"><br></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 18, 2016 at 3:12 PM, Francesco Romani <span dir="ltr"><<a href="mailto:fromani@redhat.com" target="_blank">fromani@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">----- Original Message -----<br>
> From: "Yaniv Bronheim" <<a href="mailto:ybronhei@redhat.com">ybronhei@redhat.com</a>><br>
> To: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>>, "Shahar Havivi" <<a href="mailto:shavivi@redhat.com">shavivi@redhat.com</a>>, "Francesco Romani" <<a href="mailto:fromani@redhat.com">fromani@redhat.com</a>>, "Nir<br>
> Soffer" <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>><br>
> Sent: Monday, January 18, 2016 11:01:10 AM<br>
> Subject: Ensure processes death by terminating decorator - <a href="https://gerrit.ovirt.org/51407" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/51407</a><br>
><br>
> Hi guys,<br>
><br>
> Following the work to omit deathSignal attribute from our cpopen<br>
> implementation we posted <a href="https://gerrit.ovirt.org/51407" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/51407</a> which is ready for<br>
> use.<br>
> Currently locations that should use it are:<br>
> (I wrote above who I expect to check the area and post a patch for that -<br>
> we'll discuss it during next vdsm-sync to follow the work)<br>
<br>
</span><span class="">> fromani:<br>
> vdsm_hooks/checkimages/before_vm_start.py - in checkImage - the code looks<br>
> ok, but check if not better to use the terminating decorator.. I think it<br>
> will be nicer<br>
<br>
</span>Fair enough, posted <a href="https://gerrit.ovirt.org/52349" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/52349</a><br>
<span class=""><br>
> some places define deathSignal for no reason, the call is sync - please<br>
> remove those places:<br>
</span>[...]<br>
> fromani:<br>
> lib/vdsm/virtsparsify.py<br>
<br>
Done in <a href="https://gerrit.ovirt.org/52357" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/52357</a><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
--<br>
Francesco Romani<br>
RedHat Engineering Virtualization R & D<br>
Phone: 8261328<br>
IRC: fromani<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8px"><b>Yaniv Bronhaim.</b></span><br></div></div></div></div></div>
</div>