<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 8, 2016 at 2:09 PM, Martin Perina <span dir="ltr"><<a href="mailto:mperina@redhat.com" target="_blank">mperina@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class=""><br>
<br>
----- Original Message -----<br>
> From: "Yaniv Bronheim" <<a href="mailto:ybronhei@redhat.com">ybronhei@redhat.com</a>><br>
</span><span class="">> To: "Sandro Bonazzola" <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>><br>
> Cc: "Dan Kenigsberg" <<a href="mailto:danken@redhat.com">danken@redhat.com</a>>, "Nir Soffer" <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>>, "Martin Perina" <<a href="mailto:mperina@redhat.com">mperina@redhat.com</a>>,<br>
> "Francesco Romani" <<a href="mailto:fromani@redhat.com">fromani@redhat.com</a>>, "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
</span><span class="">> Sent: Tuesday, March 8, 2016 12:54:29 PM<br>
> Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm versioning system need to be fixed<br>
><br>
</span><span class="">> latest is 4.17.19 right? so where we test latest 3.6 we checkout ovirt-3.6<br>
> branch, build the rpms and install them - can we do it when we disable the<br>
> stable repository and remove the current installed version?<br>
<br>
</span>With the above we cannot test upgrades from stable to snapshot ...<br>
<span class=""><br>
><br>
> Its either that, or each tag to stable will follow tag to latest 3.6 which<br>
> will be higher<br>
<br>
</span>Yes, that would help the CI, there's no other way than having snapshot<br>
version higher than stable version.<br></blockquote><div><br></div><div>right. I just tagged ovirt-3.6 (last snapshot) with v4.17.24</div><div>ovirt-3.6.3 last tag is v4.17.23 - from now on we'll tag ovirt-3.6.3 with v4.17.23.x util raising latest 3.6 tag </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div class="h5"><br>
><br>
><br>
> On Tue, Mar 8, 2016 at 10:52 AM, Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>><br>
> wrote:<br>
><br>
> ><br>
> ><br>
> > On Tue, Mar 8, 2016 at 9:45 AM, Yaniv Bronheim <<a href="mailto:ybronhei@redhat.com">ybronhei@redhat.com</a>><br>
> > wrote:<br>
> ><br>
> >> No. the jobs alright. ovirt-3.6 build each night will output vdsm<br>
> >> 4.17.19. older version than the build for ovirt-3.6.3 which will raise<br>
> >> (currently 4.17.23). That's all we wanted, no ? once 3.6.3 will end,<br>
> >> ovirt-3.6 new tag will be the newer version for users that want it<br>
> >><br>
> ><br>
> ><br>
> > Yaniv, when you release 4.17.23, other projects like Hosted Engine will<br>
> > require it. And if it's not available in snapshot repository you'll end up<br>
> > with a broken dependency there, since you're requiring >= 4.17.23-0 and you<br>
> > have only 4.17.19-39 which should be the one you're supposed to test. Note<br>
> > that enabling the stable repo will provide 4.17.23 required by Hosted<br>
> > engine but won't allow you to test new code since the upgrade won't be<br>
> > possible.<br>
> ><br>
> > If you don't want new vdsm code to be tested, just let me know, I'll add<br>
> > stable repository to all projects requiring vdsm and I'll solve the<br>
> > dependency breakage.<br>
> ><br>
> ><br>
> ><br>
> ><br>
> ><br>
> >><br>
> >> On Tue, Mar 8, 2016 at 10:30 AM, Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>><br>
> >> wrote:<br>
> >><br>
> >>><br>
> >>><br>
> >>> On Tue, Mar 8, 2016 at 9:07 AM, Yaniv Bronheim <<a href="mailto:ybronhei@redhat.com">ybronhei@redhat.com</a>><br>
> >>> wrote:<br>
> >>><br>
> >>>> its reasonable that you can't upgrade 4.17.23 to 4.17.19 and it<br>
> >>>> shouldn't be that way.. latest (which afaiu means latest snapshot?<br>
> >>>> ovirt-3.6.3) should get higher numbering than last stable (which should<br>
> >>>> be<br>
> >>>> last tag on ovirt-3.6 branch). in other words, tags in ovirt-3.6.3 must<br>
> >>>> be<br>
> >>>> newer than tags in ovirt-3.6 branch until we stop to update ovirt-3.6.3<br>
> >>>> and<br>
> >>>> backport only to ovirt-3.6 - than we can continue to tag ovirt-3.6.<br>
> >>>> bottom<br>
> >>>> line, as I see it - as long as ovirt-3.6.3 alive we raise the tagging<br>
> >>>> only<br>
> >>>> there<br>
> >>>><br>
> >>>><br>
> >>> this breaks automation at several layers.<br>
> >>> are you saying that we shouldn't put in ovirt-master-snapshot what comes<br>
> >>> out from ovirt-3.6 branch but push there only the output of 3.6.3 branch?<br>
> >>> If so, at least 3 new jenkins jobs (check patch, check merge, build<br>
> >>> artifact) have to be created and the nightly publisher need to be<br>
> >>> updated.<br>
> >>> Who's maintaining VDSM jenkins jobs?<br>
> >>><br>
> >>><br>
> >>><br>
> >>><br>
> >>>><br>
> >>>><br>
> >>>> On Mon, Mar 7, 2016 at 6:39 PM, Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>><br>
> >>>> wrote:<br>
> >>>><br>
> >>>>><br>
> >>>>><br>
> >>>>> On Mon, Mar 7, 2016 at 1:29 PM, Yaniv Bronheim <<a href="mailto:ybronhei@redhat.com">ybronhei@redhat.com</a>><br>
> >>>>> wrote:<br>
> >>>>><br>
> >>>>>> Again, I should understand the direction you ack here ... and its not<br>
> >>>>>> clear in any way I try to read it<br>
> >>>>>> lets summaries current status:<br>
> >>>>>> master == v4.17.999 (I recalled 4.18 tag for 4.0... probably it<br>
> >>>>>> hasn't happened yet)<br>
> >>>>>> ovit-3.6.3 last commit points to v4.17.23 (and also contains in its<br>
> >>>>>> history 4.17.22 4.17.21 4.17.20 and 4.17.19<br>
> >>>>>> ovirt-3.6 == was not tagged since v4.17.19<br>
> >>>>>><br>
> >>>>>> So, as far as I see - last "official published" version is tagged<br>
> >>>>>> anyway. once we'll finish with z-streams, we can continue tagging only<br>
> >>>>>> on<br>
> >>>>>> ovirt-3.6 branch. but as long as we publish new snapshots (or z-stream<br>
> >>>>>> releases as I call them) we can continue the tagging only on<br>
> >>>>>> ovirt-3.6.3<br>
> >>>>>> branch<br>
> >>>>>><br>
> >>>>>> The rest of your suggestions can't help in any way. if you prefer you<br>
> >>>>>> can use 4th level versioning (4.17.x-y) later on. but currently we<br>
> >>>>>> just<br>
> >>>>>> continue to raise the current 4.17 we have<br>
> >>>>>><br>
> >>>>>> now, getting back to the origin mail that Sandro sent:<br>
> >>>>>><br>
> >>>>>> """ snip<br>
> >>>>>> > vdsm-4.17.19-32.git171584b.el7.centos.src.rpm<br>
</div></div>> >>>>>> <<a href="http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/vdsm_3.6_build-artifacts-el7-x86_64/178/artifact/exported-artifacts/vdsm-4.17.19-32.git171584b.el7.centos.src.rpm</a>><br>
<div><div class="h5">> >>>>>> because<br>
> >>>>>> the last tag on the 3.6 branch was 4.17.19 and new tags have been<br>
> >>>>>> created<br>
> >>>>>> in different branches.<br>
> >>>>>><br>
> >>>>>> this is correct - no problem with that approach, new tag still will<br>
> >>>>>> be higher then 4.17.19 as we see with 4.17.23<br>
> >>>>>><br>
> >>>>>> > This make impossible to upgrade from stable (4.17.23) to latest<br>
> >>>>>> snapshot.<br>
> >>>>>><br>
> >>>>>> But we just said that stable (ovirt-3.6) is 4.17.19 and latest is<br>
> >>>>>> 4.17.23 - so it sounds right to me.<br>
> >>>>>><br>
> >>>>><br>
> >>>>><br>
> >>>>> No, we said that stable is 4.17.23 and latest is 4.17.19. So we can't<br>
> >>>>> upgrade from stable to latest, since latest has lower version than<br>
> >>>>> stable.<br>
> >>>>><br>
> >>>>> Let's make it simple, try install stable and then try to upgrade to<br>
> >>>>> snapshot.<br>
> >>>>><br>
> >>>>> You'll see yourself.<br>
> >>>>><br>
> >>>>><br>
> >>>>><br>
> >>>>><br>
> >>>>>><br>
> >>>>>> > This also break dependencies on other projects requiring the latest<br>
> >>>>>> released version like hosted engine.<br>
> >>>>>><br>
> >>>>>> No its not. HE may require 4.17.23 which is the latest we publish as<br>
> >>>>>> part of 3.6.3<br>
> >>>>>><br>
> >>>>>> """<br>
> >>>>>><br>
> >>>>>> Yaniv Bronhaim.<br>
> >>>>>><br>
> >>>>>> On Mon, Mar 7, 2016 at 1:58 PM, Dan Kenigsberg <<a href="mailto:danken@redhat.com">danken@redhat.com</a>><br>
> >>>>>> wrote:<br>
> >>>>>><br>
> >>>>>>> On Mon, Mar 07, 2016 at 12:06:32PM +0200, Nir Soffer wrote:<br>
> >>>>>>> > +1<br>
> >>>>>>> ><br>
> >>>>>>> > On Mon, Mar 7, 2016 at 10:29 AM, Sandro Bonazzola <<br>
> >>>>>>> <a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>> wrote:<br>
> >>>>>>> > ><br>
> >>>>>>> > ><br>
> >>>>>>> > > On Mon, Mar 7, 2016 at 9:03 AM, Martin Perina <<br>
> >>>>>>> <a href="mailto:mperina@redhat.com">mperina@redhat.com</a>> wrote:<br>
> >>>>>>> > >><br>
> >>>>>>> > >><br>
> >>>>>>> > >><br>
> >>>>>>> > >> ----- Original Message -----<br>
> >>>>>>> > >> > From: "Yaniv Bronheim" <<a href="mailto:ybronhei@redhat.com">ybronhei@redhat.com</a>><br>
> >>>>>>> > >> > To: "Martin Perina" <<a href="mailto:mperina@redhat.com">mperina@redhat.com</a>><br>
> >>>>>>> > >> > Cc: "Nir Soffer" <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>>, "Sandro Bonazzola"<br>
> >>>>>>> > >> > <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>>, "Francesco Romani"<br>
> >>>>>>> > >> > <<a href="mailto:fromani@redhat.com">fromani@redhat.com</a>>, "Dan Kenigsberg" <<a href="mailto:danken@redhat.com">danken@redhat.com</a>>,<br>
> >>>>>>> "devel"<br>
> >>>>>>> > >> > <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
> >>>>>>> > >> > Sent: Monday, March 7, 2016 8:16:05 AM<br>
> >>>>>>> > >> > Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] vdsm<br>
> >>>>>>> versioning<br>
> >>>>>>> > >> > system need to be fixed<br>
> >>>>>>> > >> ><br>
> >>>>>>> > >> > I don't understand what's the different .. that's what we<br>
> >>>>>>> currently do.<br>
> >>>>>>> > >> > Sandro complains that he can't upgrade latest stable which<br>
> >>>>>>> can be<br>
> >>>>>>> > >> > 4.17.23<br>
> >>>>>>> > >> > to latest snapshot which can be 4.17.19.88 \ 4.17.19-88 - yum<br>
> >>>>>>> can't<br>
> >>>>>>> > >> > consider that as an upgrade and 4.17.19.88 can't fill HE<br>
> >>>>>>> requirement for<br>
> >>>>>>> > >> > 4.17.23<br>
> >>>>>>> > >><br>
> >>>>>>> > >> oVirt 3.6 stable release:<br>
> >>>>>>> > >> - current [1]: vdsm-4.17.23-0.el7.centos.noarch.rpm<br>
> >>>>>>> > >> - desired: vdsm-4.17.23-1.el7.centos.noarch.rpm<br>
> >>>>>>> > >><br>
> >>>>>>> > >> oVirt 3.6 stable snapshot:<br>
> >>>>>>> > >> - current [2]:<br>
> >>>>>>> vdsm-4.17.19-32.git171584b.el7.centos.noarch.rpm<br>
> >>>>>>> > >> - desired:<br>
> >>>>>>> vdsm-4.17.24-0.1.git171584b.el7.centos.noarch.rpm<br>
> >>>>>>> > >><br>
> >>>>>>> > >> oVirt master snapshot:<br>
> >>>>>>> > >> - current [3]:<br>
> >>>>>>> vdsm-4.17.999-680.gitd87d031.el7.centos.noarch.rpm<br>
> >>>>>>> > >> - desired:<br>
> >>>>>>> vdsm-4.18.0-0.680.gitd87d031.el7.centos.noarch.rpm or<br>
> >>>>>>> > >><br>
> >>>>>>> vdsm-5.0.0-0.680.gitd87d031.el7.centos.noarch.rpm<br>
> >>>>>>> > >> (not sure what will be oVirt 4 vdsm version)<br>
> >>>>>>> > >><br>
> >>>>>>> > ><br>
> >>>>>>> > ><br>
> >>>>>>> > > +1<br>
> >>>>>>><br>
> >>>>>>> the down side of that is that we'd need to forsake our ability to<br>
> >>>>>>> release a new version by a mere `git tag`, and would have to include<br>
> >>>>>>> a<br>
> >>>>>>> version bump commit instead.<br>
> >>>>>>><br>
> >>>>>><br>
> >>>>>><br>
> >>>>>><br>
> >>>>>> --<br>
</div></div>> >>>>>> *Yaniv Bronhaim.*<br>
<span class="">> >>>>>><br>
> >>>>><br>
> >>>>><br>
> >>>>><br>
> >>>>> --<br>
> >>>>> Sandro Bonazzola<br>
> >>>>> Better technology. Faster innovation. Powered by community<br>
> >>>>> collaboration.<br>
> >>>>> See how it works at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a><br>
> >>>>><br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> --<br>
</span>> >>>> *Yaniv Bronhaim.*<br>
<span class="">> >>>><br>
> >>><br>
> >>><br>
> >>><br>
> >>> --<br>
> >>> Sandro Bonazzola<br>
> >>> Better technology. Faster innovation. Powered by community collaboration.<br>
> >>> See how it works at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a><br>
> >>><br>
> >><br>
> >><br>
> >><br>
> >> --<br>
</span>> >> *Yaniv Bronhaim.*<br>
<span class="">> >><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > Sandro Bonazzola<br>
> > Better technology. Faster innovation. Powered by community collaboration.<br>
> > See how it works at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a><br>
> ><br>
><br>
><br>
><br>
> --<br>
</span>> *Yaniv Bronhaim.*<br>
><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8px"><b>Yaniv Bronhaim.</b></span><br></div></div></div></div></div>
</div></div>