<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 6, 2016 at 2:23 PM, David Caro <span dir="ltr"><<a href="mailto:dcaro@redhat.com" target="_blank">dcaro@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 04/06 14:19, Edward Haas wrote:<br>
> On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal <<a href="mailto:mzamazal@redhat.com">mzamazal@redhat.com</a>> wrote:<br>
><br>
> > Edward Haas <<a href="mailto:ehaas@redhat.com">ehaas@redhat.com</a>> writes:<br>
> ><br>
> > > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal <<a href="mailto:mzamazal@redhat.com">mzamazal@redhat.com</a>><br>
> > wrote:<br>
> > ><br>
> > > Thank you, Edward, this is useful not only for CI. I use docker for<br>
> > > building Vdsm and running its unit tests and this helped me to get<br>
> > the<br>
> > > proper updated set of packages after recent changes in Vdsm.<br>
> > ><br>
> > > BTW, it seems that the following packages should be additionally<br>
> > added<br>
> > > for `make check-all': psmisc, which, python-ioprocess<br>
> > ><br>
> > ><br>
> > > Are you saying that make check is passing on your local machine?<br>
> ><br>
> > When I add the packages given above, `make check-all' (as well as `make<br>
> > check') works for me except for 4 tests in lib/vdsm/schedule.py that<br>
> > produce the following errors with `make check-all':<br>
> ><br>
> > File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line 134,<br>
> > in schedule<br>
> > heapq.heappush(self._calls, (deadline, call))<br>
> > nose.proxy.TypeError: unorderable types: ScheduledCall() <<br>
> > ScheduledCall()<br>
> ><br>
> > File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line<br>
> > 160, in test_latency<br>
> > med = ticker.latency[len(ticker.latency) / 2]<br>
> > nose.proxy.TypeError: list indices must be integers, not float<br>
> ><br>
> > Those are probably Python 3 failures that should be fixed in Vdsm.<br>
> > The docker environment works fine for running the unit tests on my<br>
> > machine.<br>
> ><br>
><br>
> I ran it on Travis CI with your recommended addition, and I am getting this<br>
> result: FAILED (SKIP=107, errors=14):<br>
> You can view the run here: <a href="https://travis-ci.org/EdDev/vdsm/builds/121117253" rel="noreferrer" target="_blank">https://travis-ci.org/EdDev/vdsm/builds/121117253</a><br>
<br>
<br>
</div></div>Afaik, you won't be able to run any tests that touch networking, or kernel<br>
modules (bonding and such). That is as much a limitation of travis as of<br>
docker, that was one of the points why we started using chroots instead of<br>
docker containers on ovirt ci.<br></blockquote><div><br></div><div>Yes, that is why I intended it for unit tests only, not for integration or functional.<br></div><div>We may find some integration tests that do pass, that needs some more investigation, but it's out of my original intent<br>.<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
David Caro<br>
<br>
Red Hat S.L.<br>
Continuous Integration Engineer - EMEA ENG Virtualization R&D<br>
<br>
Tel.: <a href="tel:%2B420%20532%20294%20605" value="+420532294605">+420 532 294 605</a><br>
Email: <a href="mailto:dcaro@redhat.com">dcaro@redhat.com</a><br>
IRC: dcaro|dcaroest@{freenode|oftc|redhat}<br>
Web: <a href="http://www.redhat.com" rel="noreferrer" target="_blank">www.redhat.com</a><br>
RHT Global #: 82-62605<br>
</font></span></blockquote></div><br></div></div>