<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 6, 2016 at 2:23 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Wed, Apr 6, 2016 at 2:19 PM, Edward Haas <<a href="mailto:ehaas@redhat.com">ehaas@redhat.com</a>> wrote:<br>
><br>
><br>
> On Wed, Apr 6, 2016 at 1:41 PM, Milan Zamazal <<a href="mailto:mzamazal@redhat.com">mzamazal@redhat.com</a>> wrote:<br>
>><br>
>> Edward Haas <<a href="mailto:ehaas@redhat.com">ehaas@redhat.com</a>> writes:<br>
>><br>
>> > On Wed, Apr 6, 2016 at 11:39 AM, Milan Zamazal <<a href="mailto:mzamazal@redhat.com">mzamazal@redhat.com</a>><br>
>> > wrote:<br>
>> ><br>
>> > Thank you, Edward, this is useful not only for CI. I use docker for<br>
>> > building Vdsm and running its unit tests and this helped me to get<br>
>> > the<br>
>> > proper updated set of packages after recent changes in Vdsm.<br>
>> ><br>
>> > BTW, it seems that the following packages should be additionally<br>
>> > added<br>
>> > for `make check-all': psmisc, which, python-ioprocess<br>
>> ><br>
>> ><br>
>> > Are you saying that make check is passing on your local machine?<br>
>><br>
>> When I add the packages given above, `make check-all' (as well as `make<br>
>> check') works for me except for 4 tests in lib/vdsm/schedule.py that<br>
>> produce the following errors with `make check-all':<br>
>><br>
>> File "/home/pdm/ovirt/vdsm/vdsm-test/lib/vdsm/schedule.py", line 134,<br>
>> in schedule<br>
>> heapq.heappush(self._calls, (deadline, call))<br>
>> nose.proxy.TypeError: unorderable types: ScheduledCall() <<br>
>> ScheduledCall()<br>
>><br>
>> File "/home/pdm/ovirt/vdsm/vdsm-test/tests/scheduleTests.py", line<br>
>> 160, in test_latency<br>
>> med = ticker.latency[len(ticker.latency) / 2]<br>
>> nose.proxy.TypeError: list indices must be integers, not float<br>
>><br>
>> Those are probably Python 3 failures that should be fixed in Vdsm.<br>
>> The docker environment works fine for running the unit tests on my<br>
>> machine.<br>
><br>
><br>
> I ran it on Travis CI with your recommended addition, and I am getting this<br>
> result: FAILED (SKIP=107, errors=14):<br>
> You can view the run here: <a href="https://travis-ci.org/EdDev/vdsm/builds/121117253" rel="noreferrer" target="_blank">https://travis-ci.org/EdDev/vdsm/builds/121117253</a><br>
<br>
</div></div>Sure, make check in master run tests that should not run on travis.<br>
<br>
Try the travis branch - after adding ioprocess to the docker image,<br>
all tests should pass:<br>
<a href="https://gerrit.ovirt.org/55738" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/55738</a><br>
<span class="HOEnZb"><font color="#888888"><br>
Nir<br>
</font></span></blockquote></div><br></div><div class="gmail_extra">Ok, will check it as well.<br></div><div class="gmail_extra">But its a bit of a lie, many tests are skipped instead of not ran at all, this needs to be fixed.<br></div><div class="gmail_extra">In addition, I find many tests as not unit tests, all tests should pass in a few seconds not in 2 minutes.<br><br></div></div>