<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 14, 2016 at 10:59 AM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span>On Thu, Apr 14, 2016 at 10:45 AM, Yaniv Bronheim <<a href="mailto:ybronhei@redhat.com" target="_blank">ybronhei@redhat.com</a>> wrote:<br>
</span><span>> I don't think this package is available in epel. if not, just remove it from<br>
> py3 list<br>
><br>
> about why we didn't catch it in jenkins - its because I don't run "make<br>
> check" anymore over el7 to save resources. we just build the rpm there to<br>
> see that we don't miss any dependencies.<br>
> maybe we should bring back the make check there ... what do you think?<br>
<br>
</span>We should, make check takes about 1.5 minutes, typical build time is<br>
about 10 minutes<br>
<br>
fc23 build, with make check: 10:19<br>
<a href="http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/5210/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/5210/console</a></blockquote><div><br></div><div>It can be drastically reduced, just by running it into RAM. </div><div>I can run both EL7 and FC23 concurrently, on my laptop, @ about 5:15. Till they fail.</div><div><br></div><div>EL7 make check fails on:<br></div><div><div>/usr/bin/pep8 --exclude="${exclude}" --filename '*.py' . \</div><div>contrib/logdb contrib/profile-stats contrib/repoplot init/daemonAdapter vdsm/get-conf-item vdsm/set-conf-item vdsm/supervdsmServer vdsm/vdsm vdsm/vdsm-restore-net-config vdsm/storage/curl-img-wrap vdsm/storage/fc-scan vdsm-tool/vdsm-tool</div><div>./vdsm_hooks/checkips/after_get_stats.py:81:17: E126 continuation line over-indented for hanging indent</div><div>./vdsm_hooks/checkips/after_get_stats.py:88:21: E126 continuation line over-indented for hanging indent</div><div>./vdsm_hooks/checkips/after_get_stats.py:94:21: E126 continuation line over-indented for hanging indent</div><div>make: *** [pep8] Error 1</div></div><div><br></div><div><br></div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br>
<br>
el7 build, no make check: 11:53<br>
<a href="http://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/747/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/747/console</a></blockquote><div><br></div><div>I'm running both EL7 and FC23 in parallel.</div><div>Y.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br>
<br>
travis build: 3-4 minutes<br>
<a href="https://travis-ci.org/nirs/vdsm/builds" rel="noreferrer" target="_blank">https://travis-ci.org/nirs/vdsm/builds</a><br>
<br>
The time of the tests does not make a real difference, and we know<br>
that the (some) code<br>
works on both platforms.<br>
<br>
We should work on reducing the build time, 10 minutes for running<br>
tests that take<br>
1.5 minutes is crazy overhead.<br>
<span><font color="#888888"><br>
Nir<br>
</font></span><div><div><br>
><br>
> On Thu, Apr 14, 2016 at 10:26 AM, Francesco Romani <<a href="mailto:fromani@redhat.com" target="_blank">fromani@redhat.com</a>><br>
> wrote:<br>
>><br>
>><br>
>> ________________________________<br>
>><br>
>> From: "Sandro Bonazzola" <<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>><br>
>> To: "Francesco Romani" <<a href="mailto:fromani@redhat.com" target="_blank">fromani@redhat.com</a>><br>
>> Cc: "Eyal Edri" <<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>>, "Dan Kenigsberg" <<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>>,<br>
>> "devel" <<a href="mailto:devel@ovirt.org" target="_blank">devel@ovirt.org</a>>, "Yaniv Bronheim" <<a href="mailto:ybronhei@redhat.com" target="_blank">ybronhei@redhat.com</a>>, "Nir<br>
>> Soffer" <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>><br>
>> Sent: Thursday, April 14, 2016 9:13:04 AM<br>
>><br>
>> Subject: Re: [ovirt-devel] [ACTION REQUIRED]<br>
>> vdsm_master_build-artifacts-fc23-x86_64 is failing due to missing dep on<br>
>> fc23 .packages<br>
>><br>
>><br>
>><br>
>> On Thu, Apr 14, 2016 at 9:12 AM, Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>><br>
>> wrote:<br>
>>><br>
>>><br>
>>><br>
>>> On Thu, Apr 14, 2016 at 9:01 AM, Francesco Romani <<a href="mailto:fromani@redhat.com" target="_blank">fromani@redhat.com</a>><br>
>>> wrote:<br>
>>>><br>
>>>><br>
>>>><br>
>>>> ________________________________<br>
>>>><br>
>>>> From: "Eyal Edri" <<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>><br>
>>>> To: "Sandro Bonazzola" <<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>><br>
>>>> Cc: "Dan Kenigsberg" <<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>>, "devel" <<a href="mailto:devel@ovirt.org" target="_blank">devel@ovirt.org</a>>,<br>
>>>> "Yaniv Bronheim" <<a href="mailto:ybronhei@redhat.com" target="_blank">ybronhei@redhat.com</a>>, "Nir Soffer" <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>>,<br>
>>>> "Francesco Romani" <<a href="mailto:fromani@redhat.com" target="_blank">fromani@redhat.com</a>><br>
>>>> Sent: Thursday, April 14, 2016 8:54:50 AM<br>
>>>> Subject: Re: [ovirt-devel] [ACTION REQUIRED]<br>
>>>> vdsm_master_build-artifacts-fc23-x86_64 is failing due to missing dep on<br>
>>>> fc23 .packages<br>
>>>><br>
>>>><br>
>>>> Don't we run it per patch as well?<br>
>>>> How did it got merged?<br>
>>>><br>
>>>> On Apr 14, 2016 9:42 AM, "Sandro Bonazzola" <<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>> wrote:<br>
>>>>><br>
>>>>><br>
>>>>> <a href="http://jenkins.ovirt.org/job/vdsm_master_build-artifacts-fc23-x86_64/823/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/vdsm_master_build-artifacts-fc23-x86_64/823/console</a><br>
>>>>><br>
>>>>> 00:05:46.751<br>
>>>>> ======================================================================<br>
>>>>> 00:05:46.751 ERROR: Failure: ImportError (No module named 'netaddr')<br>
>>>>> 00:05:46.751<br>
>>>>> ----------------------------------------------------------------------<br>
>>>>> 00:05:46.752 Traceback (most recent call last):<br>
>>>>> 00:05:46.752 File "/usr/lib/python3.4/site-packages/nose/failure.py",<br>
>>>>> line 39, in runTest<br>
>>>>> 00:05:46.752 raise self.exc_val.with_traceback(self.tb)<br>
>>>>> 00:05:46.752 File "/usr/lib/python3.4/site-packages/nose/loader.py",<br>
>>>>> line 418, in loadTestsFromName<br>
>>>>> 00:05:46.752 addr.filename, addr.module)<br>
>>>>> 00:05:46.752 File<br>
>>>>> "/usr/lib/python3.4/site-packages/nose/importer.py", line 47, in<br>
>>>>> importFromPath<br>
>>>>> 00:05:46.752 return self.importFromDir(dir_path, fqname)<br>
>>>>> 00:05:46.752 File<br>
>>>>> "/usr/lib/python3.4/site-packages/nose/importer.py", line 94, in<br>
>>>>> importFromDir<br>
>>>>> 00:05:46.753 mod = load_module(part_fqname, fh, filename, desc)<br>
>>>>> 00:05:46.753 File "/usr/lib64/python3.4/imp.py", line 235, in<br>
>>>>> load_module<br>
>>>>> 00:05:46.753 return load_source(name, filename, file)<br>
>>>>> 00:05:46.753 File "/usr/lib64/python3.4/imp.py", line 171, in<br>
>>>>> load_source<br>
>>>>> 00:05:46.753 module = methods.load()<br>
>>>>> 00:05:46.753 File "<frozen importlib._bootstrap>", line 1220, in load<br>
>>>>> 00:05:46.753 File "<frozen importlib._bootstrap>", line 1200, in<br>
>>>>> _load_unlocked<br>
>>>>> 00:05:46.753 File "<frozen importlib._bootstrap>", line 1129, in<br>
>>>>> _exec<br>
>>>>> 00:05:46.753 File "<frozen importlib._bootstrap>", line 1471, in<br>
>>>>> exec_module<br>
>>>>> 00:05:46.754 File "<frozen importlib._bootstrap>", line 321, in<br>
>>>>> _call_with_frames_removed<br>
>>>>> 00:05:46.754 File<br>
>>>>> "/home/jenkins/workspace/vdsm_master_build-artifacts-fc23-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.17.999/tests/network/models_test.py",<br>
>>>>> line 27, in <module><br>
>>>>> 00:05:46.754 from vdsm.netinfo import bonding, mtus<br>
>>>>> 00:05:46.754 File<br>
>>>>> "/home/jenkins/workspace/vdsm_master_build-artifacts-fc23-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.17.999/lib/vdsm/netinfo/__init__.py",<br>
>>>>> line 26, in <module><br>
>>>>> 00:05:46.754 from .ipwrapper import DUMMY_BRIDGE<br>
>>>>> 00:05:46.755 File<br>
>>>>> "/home/jenkins/workspace/vdsm_master_build-artifacts-fc23-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.17.999/lib/vdsm/ipwrapper.py",<br>
>>>>> line 30, in <module><br>
>>>>> 00:05:46.755 from netaddr.core import AddrFormatError<br>
>>>>> 00:05:46.755 ImportError: No module named 'netaddr'<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> Please fix ASAP.<br>
>>>><br>
>>>><br>
>>>> I think this a jenkins failure, because this seems to come from (lack<br>
>>>> of) netaddr package, which is an external package Vdsm depends on since ages<br>
>>>> (late 2013!)<br>
>>><br>
>>><br>
>>> I think it's a missing dep in build-artifacts.packages<br>
>><br>
>><br>
>> forgot to mention, please note it's the python3 package missing.<br>
>><br>
>><br>
>> yep, I think you are right. Most likely broken by<br>
>> <a href="https://gerrit.ovirt.org/#/c/55896/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/55896/</a><br>
>><br>
>> Let me quickly post a patch for this.<br>
>><br>
>> Bests,<br>
>><br>
>><br>
>> --<br>
>> Francesco Romani<br>
>> RedHat Engineering Virtualization R & D<br>
>> Phone: 8261328<br>
>> IRC: fromani<br>
><br>
><br>
><br>
><br>
> --<br>
> Yaniv Bronhaim.<br>
</div></div><div><div>_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
</div></div></blockquote></div><br></div></div>