<div dir="ltr">Okay.<div>Makes sense.</div><div>Thanks Vojtech - please also revert this one.</div><div><br></div><div>Oved</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <span dir="ltr"><<a href="mailto:vszocs@redhat.com" target="_blank">vszocs@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">(top-posting)<br>
<br>
Hi,<br>
<br>
root cause is wrong number of message parameters (placeholders)<br>
in translated properties files, compared to message definitions<br>
in Java code.<br>
<br>
For example, UIMessages#cpuInfoLabel method has 4 parameters,<br>
but the corresponding message in `UIMessages_de_DE.properties`<br>
only contains 3 placeholders.<br>
<br>
4.0 String Freeze is May 25 so it's still OK to modify message<br>
definitions in Java code.<br>
<br>
I suggest to simply revert the offending patch:<br>
<br>
translations update from zanata ovirt-3.6<br>
<a href="https://gerrit.ovirt.org/#/c/56720/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/56720/</a><br>
<br>
and create new one which doesn't introduce conflicts.<br>
<br>
We have unit tests to detect these kinds of errors, this is<br>
to ensure the build fails early on (before GWT compilation).<br>
<br>
I'm not sure why `check-patch` job for above mentioned patch<br>
didn't report the problem, since UIMessagesTest should fail,<br>
as Roman wrote below.<br>
<br>
Regards,<br>
Vojtech<br>
<span class="im HOEnZb"><br>
<br>
----- Original Message -----<br>
> From: "Marek Libra" <<a href="mailto:mlibra@redhat.com">mlibra@redhat.com</a>><br>
> To: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
</span><span class="im HOEnZb">> Sent: Wednesday, May 4, 2016 12:31:18 PM<br>
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
><br>
</span><span class="im HOEnZb">> There are issues on other keys as well.<br>
> I'm rebuilding for all locales locally now.<br>
><br>
><br>
><br>
><br>
><br>
</span><span class="im HOEnZb">> From: "Marek Libra" <<a href="mailto:mlibra@redhat.com">mlibra@redhat.com</a>><br>
> To: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
> Sent: Wednesday, May 4, 2016 11:29:55 AM<br>
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
><br>
> The fix is here: <a href="https://gerrit.ovirt.org/#/c/57007/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/57007/</a><br>
><br>
><br>
><br>
><br>
</span><div class="HOEnZb"><div class="h5">> From: "Roman Mohr" <<a href="mailto:rmohr@redhat.com">rmohr@redhat.com</a>><br>
> To: "Oved Ourfali" <<a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a>><br>
> Cc: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
> Sent: Wednesday, May 4, 2016 10:27:51 AM<br>
> Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
><br>
><br>
><br>
> On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < <a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a> > wrote:<br>
><br>
><br>
><br>
> Roman - did you build the langs in order to find the issue?<br>
><br>
> I just ran 'mvn clean verify', so I saw it on my machine. On gerrit not all<br>
> of my builds showed that error.<br>
><br>
> Looking at<br>
><br>
> <a href="https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration</a><br>
><br>
> two patches passed and two failed after a topic rebase.<br>
><br>
><br>
><br>
> Eyal - can we monitor a list of files that i changed will result in also<br>
> building all the languages?<br>
><br>
><br>
><br>
><br>
><br>
><br>
> On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < <a href="mailto:eedri@redhat.com">eedri@redhat.com</a> > wrote:<br>
><br>
><br>
><br>
> right, and we can't enable lang permutation since it takes a very long time<br>
> to run.<br>
><br>
> On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < <a href="mailto:tjelinek@redhat.com">tjelinek@redhat.com</a> > wrote:<br>
><br>
><br>
><br>
><br>
> ----- Original Message -----<br>
> > From: "Oved Ourfali" < <a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a> ><br>
> > To: "Tomas Jelinek" < <a href="mailto:tjelinek@redhat.com">tjelinek@redhat.com</a> ><br>
> > Cc: "Roman Mohr" < <a href="mailto:rmohr@redhat.com">rmohr@redhat.com</a> >, "devel" < <a href="mailto:devel@ovirt.org">devel@ovirt.org</a> >, "Scott<br>
> > Dickerson" < <a href="mailto:sdickers@redhat.com">sdickers@redhat.com</a> ><br>
> > Sent: Wednesday, May 4, 2016 9:55:40 AM<br>
> > Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
> ><br>
> > I wonder, how come the CI didn't catch that?<br>
><br>
> because this happens only when you compile with language permutations<br>
><br>
> ><br>
> > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < <a href="mailto:tjelinek@redhat.com">tjelinek@redhat.com</a> ><br>
> > wrote:<br>
> ><br>
> > > hmmm,<br>
> > > regression introduced yesterday by <a href="https://gerrit.ovirt.org/#/c/56720/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/56720/</a><br>
> > > fix on the way<br>
> > ><br>
> > > ----- Original Message -----<br>
> > > > From: "Roman Mohr" < <a href="mailto:rmohr@redhat.com">rmohr@redhat.com</a> ><br>
> > > > To: "devel" < <a href="mailto:devel@ovirt.org">devel@ovirt.org</a> ><br>
> > > > Sent: Wednesday, May 4, 2016 9:34:53 AM<br>
> > > > Subject: [ovirt-devel] Master ovirt-engine build broken<br>
> > > ><br>
> > > > Hi,<br>
> > > ><br>
> > > > I see failing tests regarding to missing translations (e.g. [1]).<br>
> > > ><br>
> > > > [...]<br>
> > > ><br>
> > > > Failed tests: doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):<br>
> > > > cpuInfoLabel does not match the number of parameters in<br>
> > > > UIMessages_zh_CN.properties(..)<br>
> > > ><br>
> > > > [...]<br>
> > > ><br>
> > > > Best Regards,<br>
> > > ><br>
> > > > Roman<br>
> > > ><br>
> > > > [1]<br>
> > > ><br>
> > > <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console</a><br>
> > > ><br>
> > > > _______________________________________________<br>
> > > > Devel mailing list<br>
> > > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > > _______________________________________________<br>
> > > Devel mailing list<br>
> > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > ><br>
> > ><br>
> > ><br>
> ><br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
><br>
><br>
><br>
><br>
><br>
> --<br>
> Eyal Edri<br>
> Associate Manager<br>
> RHEV DevOps<br>
> EMEA ENG Virtualization R&D<br>
> Red Hat Israel<br>
><br>
> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
><br>
><br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
><br>
><br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
><br>
><br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
><br>
><br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
<br>
<br>
</div></div></blockquote></div><br></div>