<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 4, 2016 at 3:41 PM, Alexander Wels <span dir="ltr"><<a href="mailto:awels@redhat.com" target="_blank">awels@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wednesday, May 04, 2016 03:38:40 PM Eyal Edri wrote:<br>
> Vojtech,<br>
> Any ideas on a test we can add to check-patch.sh (other than building all<br>
> permutations) that can help catch these ?<br>
><br>
> The original patch didn't fail on unit tests (though I can't see info since<br>
> the build got deleted, we now increased the history for builds so we will<br>
> be able to see it).<br>
> Please let me know once the translations patch is re-submitted,I'd like to<br>
> monitor it and see if CI catch any issues there.<br>
><br>
> e.<br>
><br>
<br>
</span>Eyal,<br>
<br>
I wrote a unit test specifically to catch this particular issue without having<br>
to compile all the permutations. This is what failed the build, I don't<br>
understand why it wasn't run during CI.<br></blockquote><div><br></div><div>Does it run on specific code change/path/file?</div><div>I can't check why unfortunately since the history is gone, but if you can reproduce the patch we can check.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
> On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>> wrote:<br>
> > ----- Original Message -----<br>
> ><br>
> > > From: "Vojtech Szocs" <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>><br>
> > > To: "Oved Ourfali" <<a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a>><br>
> > > Cc: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
> > > Sent: Wednesday, May 4, 2016 2:24:21 PM<br>
> > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
> > ><br>
> > ><br>
> > ><br>
> > > ----- Original Message -----<br>
> > ><br>
> > > > From: "Vojtech Szocs" <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>><br>
> > > > To: "Oved Ourfali" <<a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a>>, "David Caro"<br>
> > > > <<a href="mailto:dcaroest@redhat.com">dcaroest@redhat.com</a>><br>
> > > > Cc: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
> > > > Sent: Wednesday, May 4, 2016 2:19:09 PM<br>
> > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
> > > ><br>
> > > ><br>
> > > ><br>
> > > > ----- Original Message -----<br>
> > > ><br>
> > > > > From: "Oved Ourfali" <<a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a>><br>
> > > > > To: "Vojtech Szocs" <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>><br>
> > > > > Cc: "Marek Libra" <<a href="mailto:mlibra@redhat.com">mlibra@redhat.com</a>>, "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
> > > > > Sent: Wednesday, May 4, 2016 2:07:19 PM<br>
> > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
> > > > ><br>
> > > > > Okay.<br>
> > > > > Makes sense.<br>
> > > > > Thanks Vojtech - please also revert this one.<br>
> > > ><br>
> > > > Trying to revert master patch <a href="https://gerrit.ovirt.org/#/c/56720/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/56720/</a><br>
> > > > gives me "500 Internal server error" -- am I missing something?<br>
> > > ><br>
> > > > Perhaps oVirt gerrit maintainers can advise here? (adding David)<br>
> > ><br>
> > > Sorry for the noise, I did it manually with git revert:<br>
> > > <a href="https://gerrit.ovirt.org/#/c/57031/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/57031/</a><br>
> > ><br>
> > > Can someone please ack?<br>
> ><br>
> > Merged, this should fix the master build.<br>
> ><br>
> > > > > Oved<br>
> > > > ><br>
> > > > > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>><br>
> ><br>
> > wrote:<br>
> > > > > > (top-posting)<br>
> > > > > ><br>
> > > > > > Hi,<br>
> > > > > ><br>
> > > > > > root cause is wrong number of message parameters (placeholders)<br>
> > > > > > in translated properties files, compared to message definitions<br>
> > > > > > in Java code.<br>
> > > > > ><br>
> > > > > > For example, UIMessages#cpuInfoLabel method has 4 parameters,<br>
> > > > > > but the corresponding message in `UIMessages_de_DE.properties`<br>
> > > > > > only contains 3 placeholders.<br>
> > > > > ><br>
> > > > > > 4.0 String Freeze is May 25 so it's still OK to modify message<br>
> > > > > > definitions in Java code.<br>
> > > > > ><br>
> > > > > > I suggest to simply revert the offending patch:<br>
> > > > > > translations update from zanata ovirt-3.6<br>
> > > > > > <a href="https://gerrit.ovirt.org/#/c/56720/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/56720/</a><br>
> > > > > ><br>
> > > > > > and create new one which doesn't introduce conflicts.<br>
> > > > > ><br>
> > > > > > We have unit tests to detect these kinds of errors, this is<br>
> > > > > > to ensure the build fails early on (before GWT compilation).<br>
> > > > > ><br>
> > > > > > I'm not sure why `check-patch` job for above mentioned patch<br>
> > > > > > didn't report the problem, since UIMessagesTest should fail,<br>
> > > > > > as Roman wrote below.<br>
> > > > > ><br>
> > > > > > Regards,<br>
> > > > > > Vojtech<br>
> > > > > ><br>
> > > > > ><br>
> > > > > > ----- Original Message -----<br>
> > > > > ><br>
> > > > > > > From: "Marek Libra" <<a href="mailto:mlibra@redhat.com">mlibra@redhat.com</a>><br>
> > > > > > > To: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
> > > > > > > Sent: Wednesday, May 4, 2016 12:31:18 PM<br>
> > > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
> > > > > > ><br>
> > > > > > > There are issues on other keys as well.<br>
> > > > > > > I'm rebuilding for all locales locally now.<br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > From: "Marek Libra" <<a href="mailto:mlibra@redhat.com">mlibra@redhat.com</a>><br>
> > > > > > > To: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
> > > > > > > Sent: Wednesday, May 4, 2016 11:29:55 AM<br>
> > > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
> > > > > > ><br>
> > > > > > > The fix is here: <a href="https://gerrit.ovirt.org/#/c/57007/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/57007/</a><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > From: "Roman Mohr" <<a href="mailto:rmohr@redhat.com">rmohr@redhat.com</a>><br>
> > > > > > > To: "Oved Ourfali" <<a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a>><br>
> > > > > > > Cc: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
> > > > > > > Sent: Wednesday, May 4, 2016 10:27:51 AM<br>
> > > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali <<br>
> ><br>
> > <a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a> ><br>
> ><br>
> > > > > > wrote:<br>
> > > > > > > Roman - did you build the langs in order to find the issue?<br>
> > > > > > ><br>
> > > > > > > I just ran 'mvn clean verify', so I saw it on my machine. On<br>
> ><br>
> > gerrit<br>
> ><br>
> > > > > > > not<br>
> > > > > ><br>
> > > > > > all<br>
> > > > > ><br>
> > > > > > > of my builds showed that error.<br>
> > > > > > ><br>
> > > > > > > Looking at<br>
> ><br>
> > <a href="https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:maste</a><br>
> > r+topic:integration><br>
> > > > > > > two patches passed and two failed after a topic rebase.<br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > Eyal - can we monitor a list of files that i changed will result<br>
> ><br>
> > in<br>
> ><br>
> > > > > > > also<br>
> > > > > > > building all the languages?<br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < <a href="mailto:eedri@redhat.com">eedri@redhat.com</a> ><br>
> > > > > > > wrote:<br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > right, and we can't enable lang permutation since it takes a<br>
> > > > > > > very<br>
> > > > > > > long<br>
> > > > > ><br>
> > > > > > time<br>
> > > > > ><br>
> > > > > > > to run.<br>
> > > > > > ><br>
> > > > > > > On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek <<br>
> ><br>
> > <a href="mailto:tjelinek@redhat.com">tjelinek@redhat.com</a><br>
> ><br>
> > > > > > wrote:<br>
> > > > > > > ----- Original Message -----<br>
> > > > > > ><br>
> > > > > > > > From: "Oved Ourfali" < <a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a> ><br>
> > > > > > > > To: "Tomas Jelinek" < <a href="mailto:tjelinek@redhat.com">tjelinek@redhat.com</a> ><br>
> > > > > > > > Cc: "Roman Mohr" < <a href="mailto:rmohr@redhat.com">rmohr@redhat.com</a> >, "devel" <<br>
> ><br>
> > <a href="mailto:devel@ovirt.org">devel@ovirt.org</a> >,<br>
> ><br>
> > > > > > "Scott<br>
> > > > > ><br>
> > > > > > > > Dickerson" < <a href="mailto:sdickers@redhat.com">sdickers@redhat.com</a> ><br>
> > > > > > > > Sent: Wednesday, May 4, 2016 9:55:40 AM<br>
> > > > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken<br>
> > > > > > > ><br>
> > > > > > > > I wonder, how come the CI didn't catch that?<br>
> > > > > > ><br>
> > > > > > > because this happens only when you compile with language<br>
> ><br>
> > permutations<br>
> ><br>
> > > > > > > > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek <<br>
> > > > > > > > <a href="mailto:tjelinek@redhat.com">tjelinek@redhat.com</a><br>
> > > > > > > ><br>
> > > > > > > > wrote:<br>
> > > > > > > > > hmmm,<br>
> > > > > > > > > regression introduced yesterday by<br>
> > > > > ><br>
> > > > > > <a href="https://gerrit.ovirt.org/#/c/56720/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/56720/</a><br>
> > > > > ><br>
> > > > > > > > > fix on the way<br>
> > > > > > > > ><br>
> > > > > > > > > ----- Original Message -----<br>
> > > > > > > > ><br>
> > > > > > > > > > From: "Roman Mohr" < <a href="mailto:rmohr@redhat.com">rmohr@redhat.com</a> ><br>
> > > > > > > > > > To: "devel" < <a href="mailto:devel@ovirt.org">devel@ovirt.org</a> ><br>
> > > > > > > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM<br>
> > > > > > > > > > Subject: [ovirt-devel] Master ovirt-engine build broken<br>
> > > > > > > > > ><br>
> > > > > > > > > > Hi,<br>
> > > > > > > > > ><br>
> > > > > > > > > > I see failing tests regarding to missing translations<br>
> > > > > > > > > > (e.g.<br>
> > > > > > > > > > [1]).<br>
> > > > > > > > > ><br>
> > > > > > > > > > [...]<br>
> > > > > > > > > ><br>
> > > > > > > > > > Failed tests:<br>
> > > > > > > > > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest):<br>
> > > > > > > > > > cpuInfoLabel does not match the number of parameters in<br>
> > > > > > > > > > UIMessages_zh_CN.properties(..)<br>
> > > > > > > > > ><br>
> > > > > > > > > > [...]<br>
> > > > > > > > > ><br>
> > > > > > > > > > Best Regards,<br>
> > > > > > > > > ><br>
> > > > > > > > > > Roman<br>
> > > > > > > > > ><br>
> > > > > > > > > > [1]<br>
> ><br>
> > <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/4" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/4</a><br>
> > 07/console><br>
> > > > > > > > > > _______________________________________________<br>
> > > > > > > > > > Devel mailing list<br>
> > > > > > > > > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > > > > > > > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > > > > > > > ><br>
> > > > > > > > > _______________________________________________<br>
> > > > > > > > > Devel mailing list<br>
> > > > > > > > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > > > > > > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > > > > > ><br>
> > > > > > > _______________________________________________<br>
> > > > > > > Devel mailing list<br>
> > > > > > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > > > > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > --<br>
> > > > > > > Eyal Edri<br>
> > > > > > > Associate Manager<br>
> > > > > > > RHEV DevOps<br>
> > > > > > > EMEA ENG Virtualization R&D<br>
> > > > > > > Red Hat Israel<br>
> > > > > > ><br>
> > > > > > > phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> > > > > > > irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > _______________________________________________<br>
> > > > > > > Devel mailing list<br>
> > > > > > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > > > > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > _______________________________________________<br>
> > > > > > > Devel mailing list<br>
> > > > > > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > > > > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > _______________________________________________<br>
> > > > > > > Devel mailing list<br>
> > > > > > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > > > > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > > _______________________________________________<br>
> > > > > > > Devel mailing list<br>
> > > > > > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > > > > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > > > > ><br>
> > > > > > _______________________________________________<br>
> > > > > > Devel mailing list<br>
> > > > > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > > > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > > ><br>
> > > > _______________________________________________<br>
> > > > Devel mailing list<br>
> > > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> > ><br>
> > > _______________________________________________<br>
> > > Devel mailing list<br>
> > > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
> ><br>
> > _______________________________________________<br>
> > Devel mailing list<br>
> > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</div></div>