<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 8, 2016 at 4:11 PM, Maor Lipchuk <span dir="ltr"><<a href="mailto:mlipchuk@redhat.com" target="_blank">mlipchuk@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 8, 2016 at 2:22 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div class="h5"><div><div>On Sun, May 8, 2016 at 12:56 PM, Maor Lipchuk <<a href="mailto:mlipchuk@redhat.com" target="_blank">mlipchuk@redhat.com</a>> wrote:<br>
> Hi,<br>
><br>
> I've been trying to remove a single snapshot and consistently fail with the<br>
> following error (see [1]).<br>
><br>
> Those are my steps:<br>
> 1. Create a VM + Disk<br>
> 2. Create a snapshot<br>
> 3. Remove the snapshot<br>
><br>
> My VDSM is the latest (commit d7796fb8bdd5b424ecad54dc36cb58cd477b3224)<br>
><br>
> Is there a bug open on it? or even better, fixing patches?<br>
><br>
> [1]<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,296::fileVolume::573::Storage.Volume::(rename) Renaming<br>
> /rhev/data-center/mnt/10.35.16.43:_export_data9/e562ec63-b734-4554-b8<br>
> 2c-7fc8314c352f/images/c26b2f00-563f-4965-8bcd-e7ca8ead1625/903f5a13-f7e4-4222-bb02-303019756bb9.lease<br>
> to<br>
> /rhev/data-center/mnt/10.35.16.43:_export_data9/e562ec63-b734-4554-b82c-7fc8314c352f<br>
> /images/c26b2f00-563f-4965-8bcd-e7ca8ead1625/_remove_me_LGQXBkpd_903f5a13-f7e4-4222-bb02-303019756bb9.lease<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::ERROR::2016-05-08<br>
> 12:34:22,298::image::1338::Storage.Image::(merge) can't set attribute<br>
> Traceback (most recent call last):<br>
> File "/usr/share/vdsm/storage/image.py", line 1321, in merge<br>
> [vols[vName] for vName in chain])<br>
> File "/usr/share/vdsm/storage/image.py", line 1146, in _baseRawVolumeMerge<br>
> srcVol.rename(tmpUUID)<br>
> File "/usr/share/vdsm/storage/fileVolume.py", line 580, in rename<br>
> self._manifest.volumePath = volPath<br>
> AttributeError: can't set attribute<br>
<br>
</div></div></div></div><span class="">I think this is a bug introduced during the sdm refactorings, and I<br>
also reproduced it once<br>
but did not have time to investigate it yet.<br>
<br>
If the code expect the replace a volume path during runtime, we should<br>
have a setter:<br>
<br>
@property<br>
def volumePath(self):<br>
return self._volumePath<br>
<br>
@volumePath.setter<br>
def volumePath(self, value):<br>
self._volumePath = value<br>
<br>
You can try add this to the manifest class and see if it fixes this issue.<br></span></blockquote><div><br></div></div></div></div></blockquote><div><br></div><div>Looks like that fixes the issue.</div><div>Added a patch at <a href="https://gerrit.ovirt.org/#/c/57194/1">https://gerrit.ovirt.org/#/c/57194/1</a></div><div><br></div><div>Thanks for the help,</div><div>Maor</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div><br></div><div> <br></div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span><font color="#888888"><br>
Nir<br>
</font></span><div><div class="h5"><div><div><br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,299::resourceManager::628::Storage.ResourceManager::(releaseResource)<br>
> Trying to release resource 'e562ec63-b734-4554-b82c-7fc<br>
> 8314c352f_imageNS.c26b2f00-563f-4965-8bcd-e7ca8ead1625'<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,299::resourceManager::647::Storage.ResourceManager::(releaseResource)<br>
> Released resource 'e562ec63-b734-4554-b82c-7fc8314c352f<br>
> _imageNS.c26b2f00-563f-4965-8bcd-e7ca8ead1625' (0 active users)<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,299::resourceManager::653::Storage.ResourceManager::(releaseResource)<br>
> Resource 'e562ec63-b734-4554-b82c-7fc8314c352f_imageNS.<br>
> c26b2f00-563f-4965-8bcd-e7ca8ead1625' is free, finding out if anyone is<br>
> waiting for it.<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,299::resourceManager::628::Storage.ResourceManager::(releaseResource)<br>
> Trying to release resource 'e562ec63-b734-4554-b82c-7fc<br>
> 8314c352f_volumeNS.903f5a13-f7e4-4222-bb02-303019756bb9'<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,299::resourceManager::647::Storage.ResourceManager::(releaseResource)<br>
> Released resource 'e562ec63-b734-4554-b82c-7fc8314c352f<br>
> _volumeNS.903f5a13-f7e4-4222-bb02-303019756bb9' (0 active users)<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,299::resourceManager::653::Storage.ResourceManager::(releaseResource)<br>
> Resource 'e562ec63-b734-4554-b82c-7fc8314c352f_volumeNS<br>
> .903f5a13-f7e4-4222-bb02-303019756bb9' is free, finding out if anyone is<br>
> waiting for it.<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,299::resourceManager::661::Storage.ResourceManager::(releaseResource)<br>
> No one is waiting for resource 'e562ec63-b734-4554-b82c<br>
> -7fc8314c352f_volumeNS.903f5a13-f7e4-4222-bb02-303019756bb9', Clearing<br>
> records.<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,299::resourceManager::628::Storage.ResourceManager::(releaseResource)<br>
> Trying to release resource 'e562ec63-b734-4554-b82c-7fc<br>
> 8314c352f_volumeNS.e6d9874a-8225-44e1-9440-0a3cfd4ea7fc'<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,299::resourceManager::647::Storage.ResourceManager::(releaseResource)<br>
> Released resource 'e562ec63-b734-4554-b82c-7fc8314c352f<br>
> _volumeNS.e6d9874a-8225-44e1-9440-0a3cfd4ea7fc' (0 active users)<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,300::resourceManager::653::Storage.ResourceManager::(releaseResource)<br>
> Resource 'e562ec63-b734-4554-b82c-7fc8314c352f_volumeNS<br>
> .e6d9874a-8225-44e1-9440-0a3cfd4ea7fc' is free, finding out if anyone is<br>
> waiting for it.<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,300::resourceManager::661::Storage.ResourceManager::(releaseResource)<br>
> No one is waiting for resource 'e562ec63-b734-4554-b82c<br>
> -7fc8314c352f_volumeNS.e6d9874a-8225-44e1-9440-0a3cfd4ea7fc', Clearing<br>
> records.<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,300::resourceManager::661::Storage.ResourceManager::(releaseResource)<br>
> No one is waiting for resource 'e562ec63-b734-4554-b82c<br>
> -7fc8314c352f_imageNS.c26b2f00-563f-4965-8bcd-e7ca8ead1625', Clearing<br>
> records.<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::ERROR::2016-05-08<br>
> 12:34:22,300::task::868::Storage.TaskManager.Task::(_setError)<br>
> Task=`5b61867b-6dd4-4224-be4a-859904e3298b`::Unexpected error<br>
> Traceback (most recent call last):<br>
> File "/usr/share/vdsm/storage/task.py", line 875, in _run<br>
> return fn(*args, **kargs)<br>
> File "/usr/share/vdsm/storage/task.py", line 334, in run<br>
> return self.cmd(*self.argslist, **self.argsdict)<br>
> File "/usr/lib/python2.7/site-packages/vdsm/storage/securable.py", line<br>
> 78, in wrapper<br>
> return method(self, *args, **kwargs)<br>
> File "/usr/share/vdsm/storage/sp.py", line 1862, in mergeSnapshots<br>
> sdUUID, vmUUID, imgUUID, ancestor, successor, postZero)<br>
> File "/usr/share/vdsm/storage/image.py", line 1339, in merge<br>
> : raise se.SourceImageActionError(imgUUID, sdUUID, str(e))<br>
> SourceImageActionError: Error during source image manipulation:<br>
> "image=c26b2f00-563f-4965-8bcd-e7ca8ead1625, source<br>
> domain=e562ec63-b734-4554-b82c-7fc8314c352f: can't set attribute"<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,300::task::887::Storage.TaskManager.Task::(_run)<br>
> Task=`5b61867b-6dd4-4224-be4a-859904e3298b`::Task._run:<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b () {} failed - stopping task<br>
> 5b61867b-6dd4-4224-be4a-859904e3298b::DEBUG::2016-05-08<br>
> 12:34:22,300::task::1248::Storage.TaskManager.Task::(stop)<br>
> Task=`5b61867b-6dd4-4224-be4a-859904e3298b`::stopping in state running<br>
> (force False)<br>
><br>
><br>
><br>
> Regards,<br>
> Maor<br>
><br>
><br>
</div></div><div><div>> _______________________________________________<br>
> vdsm-devel mailing list<br>
> <a href="mailto:vdsm-devel@lists.fedorahosted.org" target="_blank">vdsm-devel@lists.fedorahosted.org</a><br>
> <a href="https://lists.fedorahosted.org/admin/lists/vdsm-devel@lists.fedorahosted.org" rel="noreferrer" target="_blank">https://lists.fedorahosted.org/admin/lists/vdsm-devel@lists.fedorahosted.org</a><br>
><br>
</div></div></div></div></blockquote></div><br></div></div>
</blockquote></div><br></div></div>