<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 29, 2016 at 12:36 PM, Dan Kenigsberg <span dir="ltr"><<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sat, May 28, 2016 at 03:16:10PM +0300, Nir Soffer wrote:<br>
> Hi all,<br>
><br>
> We have several scripts spread in the source, typically installed in<br>
> /usr/libexec/vdsm.<br>
> We had a useless WHITELIST[1], trying to compile these scripts with python3, and<br>
> we have similar (but working) whitelist for pyflakes and pep8.<br>
><br>
> To simplify the various checks, I think we need to to do this:<br>
> 1. Keep .py suffix for all python files<br>
> 2. Move all scripts to helpers/ ([2] handles storage scripts)<br>
> 3. During installation, strip the .py suffix.</span></blockquote><div> </div><div>we can leave the py suffix. it doesn't really matter</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
><br>
> With these changes, we can use the various checking commands on the entire<br>
> source tree.<br>
><br>
> For example, these commands check the entire tree:<br>
><br>
> PYTHONDONTWRITEBYTECODE=1 python3 -m compileall -f -x '(\.tox/|\.git/)' .<br>
> pep8 .<br>
> pyflakes .<br>
><br>
> Thoughts?<br>
><br>
> [1] <a href="https://gerrit.ovirt.org/58204" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/58204</a><br>
> [2] <a href="https://gerrit.ovirt.org/57363" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/57363</a><br>
<br>
</span>Sounds good, though I'd love to keep the separation of scripts into<br>
their natuaral vertical. Keep storage understand storage, etc. Why are<br>
you piling them into one source directory?<br></blockquote><div><br></div><div>I didn't comment yet because I don't like the idea behind "helpers" folder in vdsm tree, and I don't have any better offers except "scripts". we can also migrate those scripts to python.. not so sure how much value we can get from it if any</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8px"><b>Yaniv Bronhaim.</b></span><br></div></div></div></div></div>
</div></div>