<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 29, 2016 at 3:31 PM, Dan Kenigsberg <span dir="ltr"><<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5">On Sun, May 29, 2016 at 02:53:41PM +0300, Nir Soffer wrote:<br>
> On Sun, May 29, 2016 at 12:36 PM, Dan Kenigsberg <<a href="mailto:danken@redhat.com">danken@redhat.com</a>> wrote:<br>
> > On Sat, May 28, 2016 at 03:16:10PM +0300, Nir Soffer wrote:<br>
> >> Hi all,<br>
> >><br>
> >> We have several scripts spread in the source, typically installed in<br>
> >> /usr/libexec/vdsm.<br>
> >> We had a useless WHITELIST[1], trying to compile these scripts with python3, and<br>
> >> we have similar (but working) whitelist for pyflakes and pep8.<br>
> >><br>
> >> To simplify the various checks, I think we need to to do this:<br>
> >> 1. Keep .py suffix for all python files<br>
> >> 2. Move all scripts to helpers/ ([2] handles storage scripts)<br>
> >> 3. During installation, strip the .py suffix.<br>
> >><br>
> >> With these changes, we can use the various checking commands on the entire<br>
> >> source tree.<br>
> >><br>
> >> For example, these commands check the entire tree:<br>
> >><br>
> >> PYTHONDONTWRITEBYTECODE=1 python3 -m compileall -f -x '(\.tox/|\.git/)' .<br>
> >> pep8 .<br>
> >> pyflakes .<br>
> >><br>
> >> Thoughts?<br>
> >><br>
> >> [1] <a href="https://gerrit.ovirt.org/58204" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/58204</a><br>
> >> [2] <a href="https://gerrit.ovirt.org/57363" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/57363</a><br>
> ><br>
> > Sounds good, though I'd love to keep the separation of scripts into<br>
> > their natuaral vertical. Keep storage understand storage, etc. Why are<br>
> > you piling them into one source directory?<br>
><br>
> This is a separate topic.<br>
><br>
> The helpers do not belong in the library - we should keep libv/vdsm/xxx<br>
> with only the code that is needed for the xxx package. Helpers are external<br>
> programs that should have access only to public vdsm apis, so they don't<br>
> need to and should not have access to other files inside lib/vdsm/xxx.<br>
><br>
> This also make the source easier to understand, the structure is closer to<br>
> the final structure after installation.<br>
><br>
> So we can have:<br>
><br>
> helpers/storage<br>
> helpers/virt<br>
> ...<br>
><br>
> But I don't see any value in this separation, we have only about 10<br>
> helpers.<br>
><br>
> Also each directory we add adds overhead of more useless autotools<br>
> files to maintain. Look how many makefiles we got rid by moving all the<br>
> tests to one directory.<br>
<br>
</div></div>Ok, I'm convinced.<br></blockquote><div> </div><div>iiuc you plan to change the source tree only, after installation those executables will stay under<span style="color:rgb(80,0,80);font-size:12.8px"> </span><span style="color:rgb(80,0,80);font-size:12.8px">/usr/libexec/vdsm .</span></div><div><span style="color:rgb(80,0,80);font-size:12.8px">we have helper folder since </span><font color="#500050"><span style="font-size:12.8px"><a href="https://gerrit.ovirt.org/55797">https://gerrit.ovirt.org/55797</a> , now we need to expect verticals there? ok by me.</span></font></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5">_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8px"><b>Yaniv Bronhaim.</b></span><br></div></div></div></div></div>
</div></div>