<div dir="ltr">This patch failed also findbugs [1] but was merged regardless.<div>Also failed dao tests on our ci [2]</div><div><br></div><div>[1] <a href="http://jenkins-old.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/45846/">http://jenkins-old.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/45846/</a></div><div>[2] <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/7/">http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/7/</a></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 8, 2016 at 9:51 PM, Roman Mohr <span dir="ltr"><<a href="mailto:rmohr@redhat.com" target="_blank">rmohr@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi we have failing DAO tests becaus of:<br>
<br>
<a href="https://gerrit.ovirt.org/#/c/56192/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/56192/</a><br>
<br>
Seems like the cluster can't be saved anymore:<br>
<br>
testSave(org.ovirt.engine.core.dao.ClusterDaoTest) Time elapsed: 9<br>
sec <<< ERROR!<br>
java.lang.NullPointerException<br>
at org.ovirt.engine.core.dao.ClusterDaoImpl.getClusterParamSource(ClusterDaoImpl.java:255)<br>
at org.ovirt.engine.core.dao.ClusterDaoImpl.save(ClusterDaoImpl.java:136)<br>
at org.ovirt.engine.core.dao.ClusterDaoTest.testSave(ClusterDaoTest.java:318)<br>
<br>
ClusterDaoImpl.java:255 is<br>
<br>
.addValue("switch_type",<br>
cluster.getRequiredSwitchTypeForCluster().getOptionValue());<br>
<br>
Seems like the the requiredSwitchType is not set for all tests and<br>
when trying to access the getOptionValue() we have a nullpointer<br>
exception.<br>
<br>
Fails on my local machine and on travis:<br>
<a href="https://s3.amazonaws.com/archive.travis-ci.org/jobs/136184841/log.txt" rel="noreferrer" target="_blank">https://s3.amazonaws.com/archive.travis-ci.org/jobs/136184841/log.txt</a><br>
<br>
Best Regards,<br>
Roman<br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</div>