<div dir="ltr"><div>Posted a patch to fix the issue<br><br><a href="https://gerrit.ovirt.org/#/c/59290/">https://gerrit.ovirt.org/#/c/59290/</a><br><br></div>Ravi<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 15, 2016 at 6:39 PM, Yuko Katabami <span dir="ltr"><<a href="mailto:ykatabam@redhat.com" target="_blank">ykatabam@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-size:small">Thanks a lot, Martin and Ravi!</div><div><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 16, 2016 at 7:28 AM, Martin Perina <span dir="ltr"><<a href="mailto:mperina@redhat.com" target="_blank">mperina@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Wed, Jun 15, 2016 at 11:04 PM, Yuko Katabami <span dir="ltr"><<a href="mailto:ykatabam@redhat.com" target="_blank">ykatabam@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-size:small">Hi Martin,</div><div style="font-size:small"><br></div><div style="font-size:small">Thank you very much for your reply.</div><div style="font-size:small">Please see my comment inline:</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 15, 2016 at 11:50 PM, Martin Perina <span dir="ltr"><<a href="mailto:mperina@redhat.com" target="_blank">mperina@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Jun 15, 2016 at 5:35 AM, Yuko Katabami <span dir="ltr"><<a href="mailto:ykatabam@redhat.com" target="_blank">ykatabam@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div>Hi Ravi and all,</div><div><br></div><div>I am reporting the following as this may cause potential issues:</div><div><br></div><div><b>File:</b> backend/manager/modules/enginesso/src/main/resources/messages</div><div><b>Resource ID:</b> UNSUPPORTED_PARAMETER_IN_REQUEST</div><div><b>String:<div style="font-family:arial,helvetica,sans-serif;display:inline"></div> </b><div style="font-family:arial,helvetica,sans-serif;display:inline"></div>The request contains unsupported parameter value '%s' for parameter '%s'.</div></div></div></blockquote></span><div><br><div style="font-family:arial,helvetica,sans-serif;display:inline">I think we could change that to:<br><br> <b><div style="font-family:arial,helvetica,sans-serif;display:inline"></div> </b>The request contains unsupported value <div style="font-size:small;display:inline"></div>'%s' for parameter '%s'.<br></div></div></div></div></div></blockquote><div><br></div><div><div style="font-size:small;display:inline">My comment was probably not clear enough.</div> </div><div><div style="font-size:small">What I meant is that <div style="font-family:arial,helvetica,sans-serif;display:inline"></div><span style="font-family:arial,helvetica,sans-serif">'%s' is used twice in this string, one is used for "value" and the other for "parameter".</span></div><div style="font-size:small"><br></div><div style="font-size:small">When we translate, for example into Japanese, the order of words will be changed.</div><div style="font-size:small">It will look like:</div><div style="font-size:small"><br></div><div style="font-size:small">| The request | contain | of the paramater <div style="font-family:arial,helvetica,sans-serif;display:inline"></div><span style="font-family:arial,helvetica,sans-serif">'%s (parameter)' | value </span><div style="font-family:arial,helvetica,sans-serif;display:inline"></div><span style="font-family:arial,helvetica,sans-serif">'%s (value)'|</span></div><div style="font-size:small"><span style="font-family:arial,helvetica,sans-serif">but is the first </span><div style="font-family:arial,helvetica,sans-serif;display:inline"></div><span style="font-family:arial,helvetica,sans-serif">'%s' is defined to be value, and the second </span><div style="font-family:arial,helvetica,sans-serif;display:inline"></div><span style="font-family:arial,helvetica,sans-serif">'%s' is parameter, translation will be shown on UI as:</span></div><div style="font-size:small">| The request | contain | of the paramater <div style="font-family:arial,helvetica,sans-serif;display:inline"></div><span style="font-family:arial,helvetica,sans-serif">'%s (value)' | value </span><div style="font-family:arial,helvetica,sans-serif;display:inline"></div><span style="font-family:arial,helvetica,sans-serif">'%s (parameter)'|</span><span style="font-family:arial,helvetica,sans-serif"><br></span></div><div style="font-size:small"><span style="font-family:arial,helvetica,sans-serif"><br></span></div><div style="font-size:small"><span style="font-family:arial,helvetica,sans-serif">So it would be better if you can use different variables, instead of 2 x </span><div style="font-family:arial,helvetica,sans-serif;display:inline"></div><span style="font-family:arial,helvetica,sans-serif">'%s'.</span></div><div style="font-size:small"><span style="font-family:arial,helvetica,sans-serif"><br></span></div><div style="font-size:small"><span style="font-family:arial,helvetica,sans-serif">Hope this clarifies the issue.</span></div><div style="font-size:small"><span style="font-family:arial,helvetica,sans-serif"><br></span></div><div style="font-size:small"><span style="font-family:arial,helvetica,sans-serif">Thanks,</span></div><div style="font-size:small"><span style="font-family:arial,helvetica,sans-serif"><br></span></div><div style="font-size:small"><span style="font-family:arial,helvetica,sans-serif">Yuko</span></div></div></div></div></div></blockquote></div></div><div><br><div style="font-family:arial,helvetica,sans-serif;display:inline">Ahh, now I see you point :-)<br><br></div><div style="font-family:arial,helvetica,sans-serif;display:inline">Ravi, please create a patch which will add indexes to all localization strings using String.format(), for example:<br> <br><div style="font-family:arial,helvetica,sans-serif;display:inline"> </div>The request contains unsupported parameter value '%1$s' for parameter '%2$s'.<br><br></div><div style="font-family:arial,helvetica,sans-serif;display:inline">Thanks<br><br></div><div style="font-family:arial,helvetica,sans-serif;display:inline">Martin<br><br></div><div style="font-family:arial,helvetica,sans-serif;display:inline"></div> </div><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div style="font-size:small"><span style="font-family:arial,helvetica,sans-serif"><br></span></div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div style="font-family:arial,helvetica,sans-serif;display:inline"><br></div><div style="font-family:arial,helvetica,sans-serif;display:inline">Yuko, is it OK? If so, Ravi could you post a patch?<br><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span><div dir="ltr"><div><div><b>Question: </b>Using the same variables in a single sentence would cause problem when it is translated as the order of words may be changed. It should use different variables.</div><div><br></div><div>Kind regards,</div><div><br></div><div>Yuko</div></div>
</div>
<br></span>_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br></blockquote></div><br></div></div>
</blockquote></div><br><br clear="all"><div><div style="font-size:small"></div><br></div>
</div></div>
</blockquote></span></div><br></div></div>
</blockquote></div><br><br clear="all"><div><br></div><div data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><br></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div></div></div></div>
</blockquote></div><br></div>