<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 20 Jun 2016, at 18:41, Piotr Kliczewski <<a href="mailto:pkliczew@redhat.com" class="">pkliczew@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Jun 20, 2016 at 6:22 PM, Nir Soffer <span dir="ltr" class=""><<a href="mailto:nsoffer@redhat.com" target="_blank" class="">nsoffer@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, Jun 20, 2016 at 11:33 AM, Martin Sivak <<a href="mailto:msivak@redhat.com" class="">msivak@redhat.com</a>> wrote:<br class="">
>> 1. Mom is still using xmlrpc<br class="">
>><br class="">
>> Mom must move to jsonrpc.<br class="">
>> Martin: can you update on progress of this work?<br class="">
><br class="">
> We would like to avoid going through VDSM completely, except from the<br class="">
> broker part. Is it possible now to "parasitically" listen to vdsm<br class="">
> events and engine commands without having to go through VDSM API?<br class="">
<br class="">
</span>Sounds like a good plan.<br class=""></blockquote></div></div></div></div></blockquote><div><br class=""></div><div class="">bypassing vdsm for mom things is a good idea, but we need to make sure we’re not killing the rest of the system</div><div class=""><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
Piotr, how far are we from letting mom listen to engine queue so it get engine<br class="">
events/responses for certain verbs?</blockquote></div></div></div></div></blockquote></div><div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">We can do it now for both events and responses. We need to remember that we would<br class=""></div><div class="">receive anything that the engine is receiving. We could do better but that it would take<br class=""></div><div class="">more time.<br class=""></div></div></div></div></div></blockquote><div><br class=""></div>so it would receive all responses for only the defined verbs?</div><div>It would wok well for getAllVmStats</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br class="">
> You can drop XML RPC,. vdsm does not depend on MOM working anymore.<br class="">
> Just the balloon and ksm stats will be missing from data that are<br class="">
> being sent to the engine.<br class=""></span></blockquote></div></div></div></div></blockquote><div><br class=""></div>and a lot of things stops working then;)</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br class="">
</span>Balloon and ksm stats are sent today from mom to vdsm, and reported by<br class="">
vdsm to engine?<br class="">
<br class="">
If vdsm is only a middleman and does not use this info, best to send<br class="">
it directly<br class="">
to engine via the stomp broker part of vdsm.<br class="">
<br class="">
Piotr, how far are we from having engine listening for mom events using the<br class="">
vdsm broker?<br class=""></blockquote></div></div></div></div></blockquote><div><br class=""></div>I don’t think we should move any monitoring pulled from libvirt into mom - it would need another expensive and problematic call</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">It can be used now but the engine needs to know to listen for them. We would <br class=""></div><div class="">need to implement engine subscriber (one class). <br class=""></div><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br class="">
> There also were some issues with eventfd in the json library, I assume<br class="">
> those are fixed now.<br class="">
<br class="">
</span>They should be fixed here:<br class="">
<a href="https://gerrit.ovirt.org/57942" rel="noreferrer" target="_blank" class="">https://gerrit.ovirt.org/57942</a><br class="">
<br class="">
But suffering from these issue show that the api was not use properly,<br class="">
you should create one client and reuse it for the entire life of the<br class="">
application.<br class="">
<span class="HOEnZb"><font color="#888888" class=""><br class="">
<br class="">
Nir<br class="">
</font></span><div class="HOEnZb"><div class="h5"><br class="">
><br class="">
> Martin<br class="">
><br class="">
> On Sun, Jun 19, 2016 at 1:02 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com" class="">nsoffer@redhat.com</a>> wrote:<br class="">
>> Hi all,<br class="">
>><br class="">
>> We are still wasting time on maintaining both xmlrpc and jsonrpc. If we kill<br class="">
>> xmlrpc, we can greatly simplify the code base, making it easier to mainain<br class="">
>> and add new features.<br class="">
>><br class="">
>> I suggest to kill xmlrpc in 4.1, and disable it *now* on master.<br class="">
>><br class="">
>> Currently the we have 3 issues:<br class="">
>><br class="">
>> 1. Mom is still using xmlrpc<br class="">
>><br class="">
>> Mom must move to jsonrpc.<br class="">
>> Martin: can you update on progress of this work?<br class="">
>><br class="">
>> 2. sos plugin using vdsClient<br class="">
>><br class="">
>> Need to port it to use jsonrpc library, or jsonrpc client<br class="">
>><br class="">
>> New jsonrpc client: <a href="https://gerrit.ovirt.org/35181" rel="noreferrer" target="_blank" class="">https://gerrit.ovirt.org/35181</a><br class="">
>><br class="">
>> 3. Engine is using xmlrpc server for ovf upload/download<br class="">
>><br class="">
>> We must support current engine in 4.1, so we cannot remove<br class="">
>> upload/download feature in this version, but we can remove the<br class="">
>> xmlrpc support in this server.<br class="">
>><br class="">
>> Currently we abuse the xmlrpc server, supporting PUT and GET for<br class="">
>> upload and download (XMLRPC is using only POST). We can disable<br class="">
>> POST requests in protocoldetector, and not register anything with<br class="">
>> the xmlrpc server.<br class="">
>><br class="">
>> Thoughts?<br class="">
>><br class="">
>> Nir<br class="">
</div></div></blockquote></div><br class=""></div></div>
_______________________________________________<br class="">Devel mailing list<br class=""><a href="mailto:Devel@ovirt.org" class="">Devel@ovirt.org</a><br class="">http://lists.ovirt.org/mailman/listinfo/devel</div></blockquote></div><br class=""></body></html>