<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 22, 2016 at 2:27 PM, Yaniv Kaul <span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Jun 22, 2016 at 12:28 PM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">After the recent merge of testing install of ovirt-cockpit-dashboard to 3.6,<div>the 4.0 tests failed also. [1]</div></div></blockquote><div><br></div></span><div>They should not have failed. The only reason they could have failed is if there were added deps - and there were - to the dashboard.</div><div>Specifically, hosted-engine-setup was added as a dep, bringing with it a huge amount of other packages (virt-viewer, which although I requested was not removed, which brings spice, which brings GTK...) - overall, ~500 RPMs (!).</div></div></div></div></blockquote><div><br></div><div><br></div><div>They failed because 4.0 was linked to 3.6, I've posted this fix: <a href="https://gerrit.ovirt.org/#/c/59603/">https://gerrit.ovirt.org/#/c/59603/</a></div><div>When we'll make it work for 4.0, we'll restore the link.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>This is the reason I thought of abandoning this patch - which I think I've commented on in the patch itself.</div><span class=""><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>And then I found out that some of the 4.0 tests are linked to 3.6 still, is this intentional?</div></div></blockquote><div><br></div></span><div>Yes, for two reasons:</div><div>1. It allows less code duplication.</div><div>2. It allows us to test 4.0 with v3 API.</div><div>3. It allows us to compare 4.0 to 3.6.x.</div><span class=""><div></div></span></div></div></div></blockquote><div><br></div><div>I'm fully aware of these, but the fact we might have different tests / deps for different version will require us at some point to split it.</div><div>And later on do some refactor to make sure we're sharing what we can to all tests.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Should we now create a new separate 4.0 test or change the link to master?</div></div></blockquote><div><br></div></span><div>We need at some point to add v4 API tests to 4.0.</div><span class=""><font color="#888888"><div>Y.</div></font></span><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div><div>lrwxrwxrwx. 1 eedri eedri 64 Jun 22 00:12 001_initialize_engine.py -> ../../basic_suite_master/test-scenarios/001_initialize_engine.py</div><div>lrwxrwxrwx. 1 eedri eedri 53 Jun 22 00:12 002_bootstrap.py -> ../../basic_suite_3.6/test-scenarios/002_bootstrap.py</div><div>lrwxrwxrwx. 1 eedri eedri 56 Jun 22 00:12 004_basic_sanity.py -> ../../basic_suite_3.6/test-scenarios/004_basic_sanity.py</div></div><div><br></div><div><br></div><div><br></div><div>[1] <a href="http://jenkins.ovirt.org/job/ovirt_4.0_system-tests/72/console" target="_blank">http://jenkins.ovirt.org/job/ovirt_4.0_system-tests/72/console</a><span><font color="#888888"><br clear="all"><div><br></div>-- <br><div data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</font></span></div></div>
</blockquote></span></div><br></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHEV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div>
</div></div>