<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 2, 2016 at 11:06 AM, Martin Polednik <span dir="ltr"><<a href="mailto:mpolednik@redhat.com" target="_blank">mpolednik@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey devels,<br>
<br>
last week, I've been working on patch series that moves most of<br>
configuration and "static" files away from our source code to a dir<br>
called "static"[1]. (based on the previous' week VDSM weekly)<br>
<br>
Current version has static dir's layout as flat - keeping all files in<br>
the directory with few exceptions (mom.d and systemd). The downside of<br>
the approach is that we still have to rename some of the files in<br>
makefile due to possibility of name clashes if we had similarly named<br>
files (50_vdsm from sudoers and 50_vdsm anything else).<br>
<br>
There is another possibility - hierarchy within the folder. Instead of current structure -<br>
<br>
static<br>
├── Makefile.am<br>
├── limits.conf<br>
├── <a href="http://logger.conf.in" rel="noreferrer" target="_blank">logger.conf.in</a><br>
├── <a href="http://mom.conf.in" rel="noreferrer" target="_blank">mom.conf.in</a><br>
├── mom.d<br>
│ ├── 00-defines.policy<br>
│ ├── 01-parameters.policy<br>
│ ├── 02-balloon.policy<br>
│ ├── 03-ksm.policy<br>
│ ├── 04-cputune.policy<br>
│ ├── 05-iotune.policy<br>
│ └── Makefile.am<br>
├── <a href="http://sudoers.vdsm.in" rel="noreferrer" target="_blank">sudoers.vdsm.in</a><br>
├── <a href="http://svdsm.logger.conf.in" rel="noreferrer" target="_blank">svdsm.logger.conf.in</a><br>
├── systemd<br>
│ ├── Makefile.am<br>
│ ├── <a href="http://mom-vdsm.service.in" rel="noreferrer" target="_blank">mom-vdsm.service.in</a><br>
│ ├── <a href="http://supervdsmd.service.in" rel="noreferrer" target="_blank">supervdsmd.service.in</a><br>
│ ├── <a href="http://vdsm-network.service.in" rel="noreferrer" target="_blank">vdsm-network.service.in</a><br>
│ └── <a href="http://vdsmd.service.in" rel="noreferrer" target="_blank">vdsmd.service.in</a><br>
├── vdsm-bonding-modprobe.conf<br>
├── vdsm-logrotate.conf<br>
├── vdsm-modules-load.d.conf<br>
├── vdsm-sysctl.conf<br>
└── <a href="http://vdsm.rwtab.in" rel="noreferrer" target="_blank">vdsm.rwtab.in</a><br>
<br>
we could structure the directory to a corresponding subfolders over<br>
the system:<br>
<br>
etc<br>
├── modprobe.d<br>
│ └── vdsm-bonding-modprobe.conf<br>
├── modules-load.d<br>
│ └── vdsm.conf<br>
├── rwtab.d<br>
│ └── vdsm<br>
├── security<br>
│ └── limits.d<br>
│ └── 99-vdsm.conf<br>
├── sudoers.d<br>
│ ├── 50_vdsm<br>
├── sysctl.d<br>
│ └── vdsm.conf<br>
└── vdsm<br>
├── logger.conf<br>
├── logrotate<br>
│ └── vdsm<br>
├── mom.conf<br>
├── mom.d<br>
│ ├── 00-defines.policy<br>
│ ├── 01-parameters.policy<br>
│ ├── 02-balloon.policy<br>
│ ├── 03-ksm.policy<br>
│ ├── 04-cputune.policy<br>
│ └── 05-iotune.policy<br>
├── svdsm.logger.conf<br>
├── vdsm.conf<br>
└── vdsm.conf.d<br></blockquote><div><br></div><div>Second approach is much better. More organized and more clean. It's more reasonable that way for developers, and having more makefiles is not a big deal. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
There is little downside to the second approach, that is more code is<br>
added to VDSM in a sense that more makefiles will have to exist. On<br>
the other hand, we can drop all the renaming and have the files named<br>
as they would be named on their destination after install.<br>
Opinions?<br>
<br>
[1]<a href="https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:static-assets" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:static-assets</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8px"><b>Yaniv Bronhaim.</b></span><br></div></div></div></div></div>
</div></div>