<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 17, 2016 at 2:25 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Aug 17, 2016 at 1:45 PM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
> I still thinks its a very valuable hook and we are aware of the fact it has<br>
> bugs, especially with patches on master branch and 4.0.<br>
><br>
> Shlomi from the infra team is working on a solution for it as we speak and<br>
> we hope to have a solution in the next few days, however it's not trival to<br>
> test and requires setting up a staging env and improve loga for the hooks<br>
> system.<br>
<br>
</span>How do you plan to solve this?<br>
<br>
Only the owner of the bug knows if the all the required patches are merged<br></blockquote><div><br></div><div>The authors should use Bug-Url on the main bug and related-to: on other patches that are related.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
and backported to the correct repositories.<br></blockquote><div><br></div><div>This is done with logic according to the bug target milestone.</div><div><br></div><div>for e.g - a patch on branch 'ovirt-engine-4.0' was merged to bug targeted to ovirt-4.0.2.</div><div>The hook should check if branch 4.0.2 exists or not, if it exists then the bug should NOT move to MODIFIED, </div><div>since it needs still backporting to ovirt-engine-4.0.2 branch. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
> On Aug 17, 2016 12:06 PM, "Eli Mesika" <<a href="mailto:emesika@redhat.com">emesika@redhat.com</a>> wrote:<br>
>><br>
>> I also got this, especially when bugs should be back-ported<br>
>> +1 for option #1<br>
>><br>
>> On Wed, Aug 17, 2016 at 10:10 AM, Yedidyah Bar David <<a href="mailto:didi@redhat.com">didi@redhat.com</a>><br>
>> wrote:<br>
>>><br>
>>> Hi all,<br>
>>><br>
>>> We currently have a bot that automatically moves bugs from POST to<br>
>>> MODIFIED<br>
>>> if all linked patches on gerrit are merged.<br>
>>><br>
>>> It happened to me personally several times that this was a wrong thing to<br>
>>> do,<br>
>>> either because a new patch was still needed but not pushed yet, or<br>
>>> because<br>
>>> an existing patch should have been back-ported to another branch and<br>
>>> wasn't<br>
>>> yet. Since I usually pay more attention to my bug in POST, I sometimes<br>
>>> missed<br>
>>> this and handled the missing patches (backports, usually) later than I<br>
>>> could<br>
>>> if left on POST.<br>
>>><br>
>>> I have a feeling I am not the only one. So I suggest to stop doing this.<br>
>>><br>
>>> I can think of several alternatives:<br>
>>><br>
>>> 1. Do nothing. I think that's reasonable - I think most people pay more<br>
>>> attention to POST bugs anyway.<br>
>>><br>
>>> 2. Set needinfo on bug owner.<br>
>>><br>
>>> 3. Send some alert email to relevant people (bug owner, existing patches<br>
>>> owners,<br>
>>> perhaps others - e.g. reviewers of existing patches, perhaps those<br>
>>> that actually reviewed, etc.). Need to think how to make it not too<br>
>>> annoying for others but<br>
>>> still effective also if owner is on long PTO or something like that. New<br>
>>> flag<br>
>>> doesn't have to be very specific - can be called something like<br>
>>> 'attention<br>
>>> needed' or something like that.<br>
>>><br>
>>> 4. Add a new flag for that and set it. This will allow easier<br>
>>> filtering/reporting.<br>
>>><br>
>>> What do you think?<br>
>>> --<br>
>>> Didi<br>
>>> ______________________________<wbr>_________________<br>
>>> Devel mailing list<br>
>>> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
>>> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
>><br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> Devel mailing list<br>
>> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
>> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div></div>