<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 17, 2016 at 5:12 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Aug 17, 2016 at 2:47 PM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
><br>
><br>
> On Wed, Aug 17, 2016 at 2:25 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>> wrote:<br>
>><br>
</span><span class="">>> On Wed, Aug 17, 2016 at 1:45 PM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
>> > I still thinks its a very valuable hook and we are aware of the fact it<br>
>> > has<br>
>> > bugs, especially with patches on master branch and 4.0.<br>
>> ><br>
>> > Shlomi from the infra team is working on a solution for it as we speak<br>
>> > and<br>
>> > we hope to have a solution in the next few days, however it's not<br>
>> > trival to<br>
>> > test and requires setting up a staging env and improve loga for the<br>
>> > hooks<br>
>> > system.<br>
>><br>
>> How do you plan to solve this?<br>
>><br>
</span><span class="">>> Only the owner of the bug knows if the all the required patches are merged<br>
><br>
><br>
</span><span class="">> The authors should use Bug-Url on the main bug and related-to: on other<br>
> patches that are related.<br>
<br>
</span>This is not possible. Many times you need series of patches to fix a bug, and<br>
you the number of patches may change during development. You start with one<br>
patch, and later you find that you need another one, so all of them will have<br>
a bug url.<br>
<br>
Practically, you should expect that all patches in the series will<br>
have a bug-url.<br>
If the hook will change the bug incorrectly someone will have to fix this, and<br>
it is very unlikely that a developer will go to clean after the hook.<br>
<span class=""><br>
>> and backported to the correct repositories.<br>
><br>
><br>
</span><span class="">> This is done with logic according to the bug target milestone.<br>
><br>
> for e.g - a patch on branch 'ovirt-engine-4.0' was merged to bug targeted to<br>
> ovirt-4.0.2.<br>
> The hook should check if branch 4.0.2 exists or not, if it exists then the<br>
> bug should NOT move to MODIFIED,<br>
> since it needs still backporting to ovirt-engine-4.0.2 branch.<br>
<br>
</span>This is too fragile. For example, maybe a 4.0.2 branch is created after<br>
the patch was merged to 4.0 branch, and the patch will be missing, although<br>
the bug is already set to modified.<br>
<br>
Setting to modified should be done by the owner of the bug, after verifying<br>
that the patches exists in correct branch.<br>
<br>
I'm not suggesting to remove the hook, just disable the feature of making<br>
a bug modified.<br></blockquote><div><br></div><div>+1. On build day checking that bugs in modified not listed in Bug-Url on the build branch due to missing backport is a painful experience.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
Nir<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a><br></div></div></div></div>
</div></div>