<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 5, 2016 at 9:04 AM, Yedidyah Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" target="_blank">didi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sun, Sep 4, 2016 at 6:55 PM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
> Any reason to keep running db upgrade jobs? [1] while we already have engine<br>
> setup+upgrade jobs running per patch? [2]<br>
<br>
</span>IMO [2] is enough. In the not-very-common event that engine-setup breaks<br>
not due to dbscripts, we should fix it quickly anyway.<br></blockquote><div><br></div><div>I agree, I'll send a patch to remove it from Jenkins,</div><div>If at any point ovirt-engine maintainer will want it, it should be added as a script under check-patch.sh.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Downside of [1] is mainly extra maintenance on your (CI) side.<br>
If you keep it, you might soon need to patch it again to support [3].<br></blockquote><div><br></div><div>I'm not too much concerned on the extra maintanance, it more dev side that is affected by it:</div><div><ol><li>One more job to wait for when sending patches, increasing queue size</li><li>Another job which is separated from standard CI increase the chance of wrong review values from CI.</li></ol></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
[3] <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1366900" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1366900</a><br>
<span class=""><br>
><br>
><br>
> [1]<br>
> <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-db-from-master_el7_created/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-engine_master_upgrade-<wbr>db-from-master_el7_created/</a><br>
> [2]<br>
> <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-4.0_el7_created/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-engine_master_upgrade-<wbr>from-4.0_el7_created/</a><br>
><br>
><br>
> --<br>
> Eyal Edri<br>
> Associate Manager<br>
> RHV DevOps<br>
> EMEA ENG Virtualization R&D<br>
> Red Hat Israel<br>
><br>
> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
><br>
</span>> ______________________________<wbr>_________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
--<br>
Didi<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div></div>