<div dir="ltr">Glad to hear you found the issue!<div>Let me know when it's merged so we can publish it to the nightlies and rerun the tests.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 6, 2016 at 11:34 AM, Juan Hernández <span dir="ltr"><<a href="mailto:jhernand@redhat.com" target="_blank">jhernand@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 09/05/2016 08:43 PM, Rafael Martins wrote:<br>
> ----- Original Message -----<br>
>> From: "Juan Hernández" <<a href="mailto:jhernand@redhat.com">jhernand@redhat.com</a>><br>
>> To: "Yaniv Kaul" <<a href="mailto:ykaul@redhat.com">ykaul@redhat.com</a>><br>
>> Cc: "Sandro Bonazzola" <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>>, "Rafael Martins" <<a href="mailto:rmartins@redhat.com">rmartins@redhat.com</a>>, "Ondra Machacek"<br>
>> <<a href="mailto:omachace@redhat.com">omachace@redhat.com</a>>, "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>><br>
>> Sent: Friday, September 2, 2016 2:31:42 PM<br>
>> Subject: Re: [ovirt-devel] Failure in log collector on master: Failure fetching information about hypervisors from<br>
>> API. Error (ValueError): legacy is not a valid RngSource<br>
>><br>
>> On 09/02/2016 02:24 PM, Yaniv Kaul wrote:<br>
>>> On Fri, Sep 2, 2016 at 3:14 PM, Juan Hernández <<a href="mailto:jhernand@redhat.com">jhernand@redhat.com</a><br>
>>> <mailto:<a href="mailto:jhernand@redhat.com">jhernand@redhat.com</a>>> wrote:<br>
>>><br>
>>> On 09/02/2016 02:00 PM, Sandro Bonazzola wrote:<br>
>>> ><br>
>>> ><br>
>>> > On Fri, Sep 2, 2016 at 1:38 PM, Yaniv Kaul <<a href="mailto:ykaul@redhat.com">ykaul@redhat.com</a><br>
>>> > <mailto:<a href="mailto:ykaul@redhat.com">ykaul@redhat.com</a>><br>
>>> > <mailto:<a href="mailto:ykaul@redhat.com">ykaul@redhat.com</a> <mailto:<a href="mailto:ykaul@redhat.com">ykaul@redhat.com</a>>>> wrote:<br>
>>> ><br>
>>> > Log:<br>
>>> ><br>
>>> > 2016-09-02 07:26:52::ERROR::hypervisors::<wbr>197::root:: Failure<br>
>>> > fetching information about hypervisors from API.<br>
>>> > Error (ValueError): legacy is not a valid RngSource<br>
>>> > 2016-09-02 07:26:52::ERROR::__main__::<wbr>1147::root::<br>
>>> > _get_hypervisors_from_api: legacy is not a valid RngSource<br>
>>> > 2016-09-02 07:26:52::INFO::__main__::<wbr>1424::root:: Gathering oVirt<br>
>>> > Engine information...<br>
>>> > 2016-09-02 07:27:03::INFO::__main__::<wbr>1398::root:: Gathering<br>
>>> > PostgreSQL the oVirt Engine database and log files from<br>
>>> > localhost...<br>
>>> > 2016-09-02 07:27:05::INFO::__main__::<wbr>1859::root:: No hypervisors<br>
>>> > were selected, therefore no hypervisor data will be collected.<br>
>>> > 2016-09-02 07:27:08::INFO::__main__::<wbr>1862::root:: Log files have<br>
>>> > been collected and placed in<br>
>>> > /tmp/sosreport-LogCollector-<wbr>20160902072705.tar.xz.<br>
>>> ><br>
>>> ><br>
>>> > I am not familiar with this error - first time I've seen it,<br>
>>> > while<br>
>>> > running on Master, on Lago (with a patch I'm working on - that<br>
>>> > adds<br>
>>> > DNS and IPv6 support to Lago, nothing more - doesn't seem<br>
>>> > relevant).<br>
>>> > Any idea?<br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> > Probably a change in the API.<br>
>>> > Rafael can you reproduce?<br>
>>> ><br>
>>> > Juan, Ondra, any insight?<br>
>>> ><br>
>>><br>
>>> That means that the API is returning "legacy" as the value for<br>
>>> something<br>
>>> that is declared of type "RngSource", and the valid values for that are<br>
>>> "random" and "hwrng". But the API can't return that, at least not<br>
>>> version 4 of the API. Are you using engine 4? Can you share the output<br>
>>> of the clusters resource?<br>
>>><br>
>>> https://.../ovirt-engine/api/<wbr>clusters<br>
>>><br>
>>><br>
>>> Lago is still using the v3 API.<br>
>>> I'm not sure what the log collector is using. I assume[1] it's v4.<br>
>>><br>
>>> Y.<br>
>>> [1]<br>
>>> <a href="https://github.com/oVirt/ovirt-log-collector/blob/dfaf35675bee3da1c53b4fd74b816efafa13d070/src/helper/hypervisors.py#L8" rel="noreferrer" target="_blank">https://github.com/oVirt/<wbr>ovirt-log-collector/blob/<wbr>dfaf35675bee3da1c53b4fd74b816e<wbr>fafa13d070/src/helper/<wbr>hypervisors.py#L8</a><br>
>>><br>
>><br>
>> But the version of the engine should be 4, if I understand correctly,<br>
>> and SDK 4 should work correctly with that version of the engine. In<br>
>> addition, if it the engine is version 3 the SDK connection should have<br>
>> failed much earlier, during authentication.<br>
><br>
> Hi Juan,<br>
><br>
> I managed to reproduce this with "basic_suite_master" test from ovirt-system-tests, that uses everything from master branch. This means that engine version is 4, not 3. It seems to be an issue with engine/sdk, as the value is actually stored on engine as "legacy". Here you can find the xml output of the endpoints you asked: <a href="https://gist.github.com/rafaelmartins/60c21e158a9e6453c14a673f77693d61" rel="noreferrer" target="_blank">https://gist.github.com/<wbr>rafaelmartins/<wbr>60c21e158a9e6453c14a673f77693d<wbr>61</a><br>
><br>
> Please let me know if you need anything else.<br>
><br>
> Thanks,<br>
> Rafael<br>
><br>
<br>
</div></div>This is a bug in the Python SDK. Should be fixed by the following patch:<br>
<br>
Fix reading of lists of elements<br>
<a href="https://gerrit.ovirt.org/63385" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/63385</a><br>
<div class="HOEnZb"><div class="h5"><br>
><br>
>>><br>
>>><br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> > Y.<br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> > --<br>
>>> > Sandro Bonazzola<br>
>>> > Better technology. Faster innovation. Powered by community<br>
>>> > collaboration.<br>
>>> > See how it works at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a> <<a href="http://redhat.com" rel="noreferrer" target="_blank">http://redhat.com</a>><br>
>>> > <<a href="http://redhat.com" rel="noreferrer" target="_blank">http://redhat.com</a>><br>
>>> ><br>
>>> <<a href="https://www.redhat.com/it/about/events/red-hat-open-source-day-2016" rel="noreferrer" target="_blank">https://www.redhat.com/it/<wbr>about/events/red-hat-open-<wbr>source-day-2016</a><br>
>>> <<a href="https://www.redhat.com/it/about/events/red-hat-open-source-day-2016" rel="noreferrer" target="_blank">https://www.redhat.com/it/<wbr>about/events/red-hat-open-<wbr>source-day-2016</a>>><br>
>>> ><br>
>>> ><br>
>>> > ______________________________<wbr>_________________<br>
>>> > Devel mailing list<br>
>>> > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a> <mailto:<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a>><br>
>>> > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
>>> <<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a>><br>
>>> ><br>
>>><br>
>>><br>
>>> --<br>
>>> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta<br>
>>> 3ºD, 28016 Madrid, Spain<br>
>>> Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat<br>
>>> S.L.<br>
>>><br>
>>><br>
>><br>
>><br>
>> --<br>
>> Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta<br>
>> 3ºD, 28016 Madrid, Spain<br>
>> Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.<br>
>><br>
> ______________________________<wbr>_________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
><br>
<br>
<br>
--<br>
Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta<br>
3ºD, 28016 Madrid, Spain<br>
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.<br>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div>