<div dir="ltr"><div><div>Hopefully this [1] patch solves the issue.<br><br></div>Thanks,<br></div>Piotr<br><div><div><br>[1] <a href="https://gerrit.ovirt.org/#/c/63685/">https://gerrit.ovirt.org/#/c/63685/</a><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 12, 2016 at 12:23 PM, Piotr Kliczewski <span dir="ltr"><<a href="mailto:piotr.kliczewski@gmail.com" target="_blank">piotr.kliczewski@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Will take a look.<br>
<div><div class="h5"><br>
On Mon, Sep 12, 2016 at 12:13 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>> wrote:<br>
> test_reject_concurrency(True) (protocoldetectorTests.<wbr>AcceptorTests)<br>
> fails once every few month.<br>
><br>
> Looks like a real issue in the actual code, doing double close.<br>
> This is a known issue in asyncore that we already fixed in few places.<br>
><br>
> Nir<br>
><br>
> ----<br>
><br>
> 11:26:48 ==============================<wbr>==============================<wbr>==========<br>
> 11:26:48 ERROR: test_reject_concurrency(True)<br>
> (protocoldetectorTests.<wbr>AcceptorTests)<br>
> 11:26:48 ------------------------------<wbr>------------------------------<wbr>----------<br>
> 11:26:48 Traceback (most recent call last):<br>
> 11:26:48 File<br>
> "/home/jenkins/workspace/vdsm_<wbr>master_check-patch-fc24-x86_<wbr>64/vdsm/tests/<wbr>protocoldetectorTests.py",<br>
> line 113, in tearDown<br>
> 11:26:48 self.acceptor.stop()<br>
> 11:26:48 File<br>
> "/home/jenkins/workspace/vdsm_<wbr>master_check-patch-fc24-x86_<wbr>64/vdsm/lib/vdsm/<wbr>protocoldetector.py",<br>
> line 211, in stop<br>
> 11:26:48 self._acceptor.close()<br>
> 11:26:48 File "/usr/lib64/python2.7/<wbr>asyncore.py", line 407, in close<br>
> 11:26:48 self.del_channel()<br>
> 11:26:48 File<br>
> "/home/jenkins/workspace/vdsm_<wbr>master_check-patch-fc24-x86_<wbr>64/vdsm/lib/yajsonrpc/<wbr>betterAsyncore.py",<br>
> line 137, in del_channel<br>
> 11:26:48 asyncore.dispatcher.del_<wbr>channel(self, map)<br>
> 11:26:48 File "/usr/lib64/python2.7/<wbr>asyncore.py", line 292, in del_channel<br>
> 11:26:48 del map[fd]<br>
> 11:26:48 KeyError: 63<br>
> 11:26:48 -------------------- >> begin captured logging << --------------------<br>
> 11:26:48 2016-09-11 11:24:27,399 INFO [vds.MultiProtocolAcceptor]<br>
> (MainThread) Listening at <a href="http://127.0.0.1:46615" rel="noreferrer" target="_blank">127.0.0.1:46615</a><br>
> 11:26:48 2016-09-11 11:24:27,399 DEBUG [vds.MultiProtocolAcceptor]<br>
> (MainThread) Adding detector <protocoldetectorTests.Echo object at<br>
> 0x7f03ee0b01d0><br>
> 11:26:48 2016-09-11 11:24:27,399 DEBUG [vds.MultiProtocolAcceptor]<br>
> (MainThread) Adding detector <protocoldetectorTests.<wbr>Uppercase object<br>
> at 0x7f03ee0b0c50><br>
> 11:26:48 2016-09-11 11:24:27,402 INFO<br>
> [ProtocolDetector.<wbr>AcceptorImpl] (Thread-191) Accepting connection from<br>
> <a href="http://127.0.0.1:38136" rel="noreferrer" target="_blank">127.0.0.1:38136</a><br>
> 11:26:48 2016-09-11 11:24:27,407 INFO<br>
> [ProtocolDetector.<wbr>AcceptorImpl] (Thread-191) Accepting connection from<br>
> <a href="http://127.0.0.1:38138" rel="noreferrer" target="_blank">127.0.0.1:38138</a><br>
> 11:26:48 2016-09-11 11:24:27,411 INFO<br>
> [ProtocolDetector.<wbr>AcceptorImpl] (Thread-191) Accepting connection from<br>
> <a href="http://127.0.0.1:38140" rel="noreferrer" target="_blank">127.0.0.1:38140</a><br>
> 11:26:48 2016-09-11 11:24:27,415 INFO<br>
> [ProtocolDetector.<wbr>AcceptorImpl] (Thread-191) Accepting connection from<br>
> <a href="http://127.0.0.1:38142" rel="noreferrer" target="_blank">127.0.0.1:38142</a><br>
> 11:26:48 2016-09-11 11:24:27,416 DEBUG [ProtocolDetector.Detector]<br>
> (Thread-191) Using required_size=9<br>
> 11:26:48 2016-09-11 11:24:27,416 WARNING [vds.dispatcher] (Thread-191)<br>
> unhandled write event<br>
> 11:26:48 2016-09-11 11:24:27,420 INFO<br>
> [ProtocolDetector.<wbr>AcceptorImpl] (Thread-191) Accepting connection from<br>
> <a href="http://127.0.0.1:38144" rel="noreferrer" target="_blank">127.0.0.1:38144</a><br>
> 11:26:48 2016-09-11 11:24:27,421 WARNING [ProtocolDetector.Detector]<br>
> (Thread-191) Unrecognized protocol: 'no such p'<br>
> 11:26:48 2016-09-11 11:24:27,427 DEBUG [ProtocolDetector.Detector]<br>
> (Thread-191) Using required_size=9<br>
> 11:26:48 2016-09-11 11:24:27,427 WARNING [vds.dispatcher] (Thread-191)<br>
> unhandled write event<br>
> 11:26:48 2016-09-11 11:24:27,428 DEBUG [ProtocolDetector.Detector]<br>
> (Thread-191) Using required_size=9<br>
> 11:26:48 2016-09-11 11:24:27,428 WARNING [vds.dispatcher] (Thread-191)<br>
> unhandled write event<br>
> 11:26:48 2016-09-11 11:24:27,429 WARNING [ProtocolDetector.Detector]<br>
> (Thread-191) Unrecognized protocol: 'no such p'<br>
> 11:26:48 2016-09-11 11:24:27,430 WARNING [ProtocolDetector.Detector]<br>
> (Thread-191) Unrecognized protocol: 'no such p'<br>
> 11:26:48 2016-09-11 11:24:27,430 DEBUG [ProtocolDetector.Detector]<br>
> (Thread-191) Using required_size=9<br>
> 11:26:48 2016-09-11 11:24:27,431 WARNING [ProtocolDetector.Detector]<br>
> (Thread-191) Unrecognized protocol: 'no such p'<br>
> 11:26:48 2016-09-11 11:24:27,433 DEBUG [ProtocolDetector.Detector]<br>
> (Thread-191) Using required_size=9<br>
> 11:26:48 2016-09-11 11:24:27,433 WARNING [ProtocolDetector.Detector]<br>
> (Thread-191) Unrecognized protocol: 'no such p'<br>
> 11:26:48 2016-09-11 11:24:27,434 DEBUG [vds.MultiProtocolAcceptor]<br>
> (MainThread) Stopping Acceptor<br>
> 11:26:48 --------------------- >> end captured logging << ---------------------<br>
</div></div>> ______________________________<wbr>_________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
</blockquote></div><br></div>