<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 20, 2016 at 9:34 AM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Mon, Sep 19, 2016 at 7:56 PM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, Sep 19, 2016 at 9:41 AM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Sun, Sep 18, 2016 at 4:18 PM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>Following [1] I'd like to propose to remove rpm building from the 'check-merged.sh' script from ovirt-engine (master for now).</div><div><br></div><div>The job [2] takes on avg 15 min while actually the rpms are built already in check-patch </div><div>(with gwt draft mode if needed) and runs exactly the same build rpm command as check-patch [3].</div><div><br></div><div>So there isn't real value in running exactly the same rpm build post merge, and we already build full permutation mode in 'build-artifacts.sh'. </div><div><br></div><div>Any reason to keep it?</div><div>We can cut down valuable time in CI if we drop it and vacant more time for more meaningful tests.</div></div></blockquote><div><br></div><div><br></div></span><div>This depends on the flow: if we make check_merge gating to the merge and to the build we should keep the rpm build becuase at merge a rebase is done automatically.</div></div></div></div></blockquote><div><br></div></span><div>What do you mean by 'gating to the merge'? I'm not sure I understand what it means.</div><div>Isn't check-patch.sh does the gating? check-merge runs post merge so its already too late to gate the code ... </div><div>And I think check-merge and check-patch currently runs the same rpmbuild command, so I don't see how check-merged has any value over check-patch.</div></div></div></div></blockquote><div><br></div></span><div>when merge command is issued a rebase is done as well. We still need a check-merged job because the code checked by check-patch is not the same anymore when check-merged runs.</div></div></div></div></blockquote><div><br></div><div>OK, now I understand, so indeed check-merge can potentially run on different code than check-patch and possibly fail due to it.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>In original desing of stdci, check-merged was supposed to become a gating test for build-artifacts.</div></div></div></div></blockquote><div><br></div><div>We have it in our backlog, i.e installing Zuul and adding gating for the check-merged jobs, its mostly relevant for system jobs, but we can defiently do it first for simple 'check-merged.sh' jobs</div><div>as part of standard CI.</div><div><br></div><div>Opened a ticket for it [1]</div><div><br></div><div>[1] <a href="https://ovirt-jira.atlassian.net/browse/OVIRT-734">https://ovirt-jira.atlassian.net/browse/OVIRT-734</a> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="gmail-h5"><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>If there's not gating process performed by check-merge then I agree in dropping rpm build.</div><span><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div><br></div><div>[1] <a href="https://ovirt-jira.atlassian.net/browse/OVIRT-416" target="_blank">https://ovirt-jira.atlassi<wbr>an.net/browse/OVIRT-416</a><br clear="all"><div>[2] <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-el7-x86_64/buildTimeTrend" target="_blank">http://jenkins.ovirt.org/j<wbr>ob/ovirt-engine_master_check-m<wbr>erged-el7-x86_64/buildTimeTren<wbr>d</a><br></div><div>[3] </div><div><div>rpmbuild \</div><div> -D "_rpmdir $PWD/output" \</div><div> -D "_topmdir $PWD/rpmbuild" \</div><div> -D "release_suffix ${SUFFIX}" \</div><div> -D "ovirt_build_ut $BUILD_UT" \</div><div> -D "ovirt_build_extra_flags $EXTRA_BUILD_FLAGS" \</div><div> -D "ovirt_build_draft 1" \</div><div> --rebuild output/*.src.rpm</div></div><span><font color="#888888"><div><br></div><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</font></span></div></div>
</blockquote></span></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a><br></div></div><div dir="ltr"><a href="https://www.redhat.com/it/about/events/red-hat-open-source-day-2016" target="_blank"><img width="420" height="60"></a><br></div></div></div></div></div>
</font></span></div></div>
</blockquote></div></div></div><div><div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a href="tel:%2B972-9-7692018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div></div></div></div>
</blockquote></div></div></div><div><div class="gmail-h5"><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a><br></div></div><div dir="ltr"><a href="https://www.redhat.com/it/about/events/red-hat-open-source-day-2016" target="_blank"><img src="http://images.engage.redhat.com/EloquaImages/clients/RedHat/%7B53f97a34-013e-4b79-966f-222f50a6de8c%7D_Red_Hat_Open_Source_Day_2_CITIES.png" width="420" height="60"></a><br></div></div></div></div></div>
</div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div></div>